fix(review-feedback-1294): address latest review comments

Author: ZhuLinsen

src/services/system_config_service.py

@@ -263,6 +263,18 @@ def _build_display_config_map(cls, raw_config_map: Dict[str, str]) -> Dict[str,
 
         return display_map
 
+    @staticmethod
+    def _resolve_display_value(raw_value: str, field_schema: Dict[str, Any]) -> str:
+        if raw_value:
+            return raw_value
+
+        if field_schema.get("ui_control") == "switch":
+            default_value = field_schema.get("default_value")
+            if isinstance(default_value, str) and default_value:
+                return default_value
+
+        return raw_value
+
     def get_config(self, include_schema: bool = True, mask_token: str = "******") -> Dict[str, Any]:
         """Return current config values without server-side secret masking."""
         config_map = self._build_display_config_map(self._manager.read_config_map())
@@ -283,9 +295,10 @@ def get_config(self, include_schema: bool = True, mask_token: str = "******") ->
         for key in all_keys:
             raw_value = config_map.get(key, "")
             field_schema = schema_by_key[key]
+            display_value = self._resolve_display_value(raw_value, field_schema)
             item: Dict[str, Any] = {
                 "key": key,
-                "value": raw_value,
+                "value": display_value,
                 "raw_value_exists": bool(raw_value),
                 "is_masked": False,
             }

tests/test_system_config_service.py

@@ -67,6 +67,27 @@ def test_get_config_returns_raw_sensitive_values(self) -> None:
         self.assertFalse(items["GEMINI_API_KEY"]["is_masked"])
         self.assertTrue(items["GEMINI_API_KEY"]["raw_value_exists"])
 
+    def test_get_config_uses_switch_default_for_missing_report_model_toggle(self) -> None:
+        payload = self.service.get_config(include_schema=True)
+        items = {item["key"]: item for item in payload["items"]}
+
+        self.assertEqual(items["REPORT_SHOW_LLM_MODEL"]["value"], "true")
+        self.assertFalse(items["REPORT_SHOW_LLM_MODEL"]["raw_value_exists"])
+
+        self._rewrite_env(
+            "STOCK_LIST=600519,000001",
+            "GEMINI_API_KEY=secret-key-value",
+            "SCHEDULE_TIME=18:00",
+            "LOG_LEVEL=INFO",
+            "REPORT_SHOW_LLM_MODEL=false",
+        )
+
+        payload = self.service.get_config(include_schema=True)
+        items = {item["key"]: item for item in payload["items"]}
+
+        self.assertEqual(items["REPORT_SHOW_LLM_MODEL"]["value"], "false")
+        self.assertTrue(items["REPORT_SHOW_LLM_MODEL"]["raw_value_exists"])
+
     def test_get_setup_status_reports_required_gaps_for_empty_config(self) -> None:
         self._rewrite_env("")