fix(review-feedback-1256): address latest review comments

Author: ZhuLinsen

apps/dsa-desktop/main.js

@@ -490,24 +490,35 @@ function restorePackagedRuntimeStateFromBackup() {
   const runtimeEntries = resolveRuntimeFileEntries(appDir);
   const relativeFiles = normalizeBackupFileList(manifest);
   const restored = [];
+  const failed = [];
 
-  relativeFiles.forEach((relativePath) => {
-    const entry = runtimeEntries.find((candidate) => candidate.relativePath === relativePath);
-    const source = path.join(backupRoot, relativePath);
-    const target = entry ? entry.absolutePath : path.join(appDir, relativePath);
-    if (!fs.existsSync(source)) {
-      return;
-    }
-    ensureDirectory(path.dirname(target));
-    fs.copyFileSync(source, target);
-    restored.push(relativePath);
-  });
-
-  cleanupUpdateBackupRoot();
+  try {
+    relativeFiles.forEach((relativePath) => {
+      try {
+        const entry = runtimeEntries.find((candidate) => candidate.relativePath === relativePath);
+        const source = path.join(backupRoot, relativePath);
+        const target = entry ? entry.absolutePath : path.join(appDir, relativePath);
+        if (!fs.existsSync(source)) {
+          return;
+        }
+        ensureDirectory(path.dirname(target));
+        fs.copyFileSync(source, target);
+        restored.push(relativePath);
+      } catch (error) {
+        const message = error instanceof Error ? error.message : String(error);
+        failed.push(`${relativePath} (${message})`);
+      }
+    });
+  } finally {
+    cleanupUpdateBackupRoot();
+  }
 
   if (restored.length) {
     console.log(`[update] restored runtime files from backup: ${restored.join(', ')}`);
   }
+  if (failed.length) {
+    logLine(`[update] skipped runtime restore files after copy failure: ${failed.join(', ')}`);
+  }
 }
 
 function resolveBackendPath() {
@@ -1529,6 +1540,7 @@ module.exports = {
   fetchLatestReleaseJson,
   normalizeVersionString,
   parseSemver,
+  restorePackagedRuntimeStateFromBackup,
   sanitizeReleaseUrl,
   stopBackend,
   __setBackendProcessForTest,

apps/dsa-desktop/tests/main.test.js

@@ -2,17 +2,21 @@ const assert = require('node:assert/strict');
 const test = require('node:test');
 const Module = require('node:module');
 const { EventEmitter } = require('node:events');
+const fs = require('node:fs');
+const os = require('node:os');
 const path = require('node:path');
 
-function loadMainModule(t) {
+function loadMainModule(t, options = {}) {
   const originalLoad = Module._load;
+  const originalPlatform = Object.getOwnPropertyDescriptor(process, 'platform');
   const fakeApp = {
     isPackaged: false,
     getVersion: () => '3.12.0',
     getPath: () => '/tmp/dsa-user-data',
     whenReady: () => ({ then: () => undefined }),
     on: () => undefined,
     quit: () => undefined,
+    ...(options.app || {}),
   };
   const fakeDialog = {
     showMessageBox: async () => ({ response: 0 }),
@@ -51,9 +55,16 @@ function loadMainModule(t) {
 
   t.after(() => {
     Module._load = originalLoad;
+    if (options.platform && originalPlatform) {
+      Object.defineProperty(process, 'platform', originalPlatform);
+    }
     delete require.cache[mainPath];
   });
 
+  if (options.platform) {
+    Object.defineProperty(process, 'platform', { ...originalPlatform, value: options.platform });
+  }
+
   return require('../main.js');
 }
 
@@ -220,6 +231,57 @@ test('desktop update backup list includes WAL and SHM artifacts', (t) => {
   assert.ok(files.includes(path.join('logs', 'desktop.log')));
 });
 
+test('restorePackagedRuntimeStateFromBackup skips failed copies and clears backup', (t) => {
+  const tempRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'dsa-desktop-restore-'));
+  const appDir = path.join(tempRoot, 'app');
+  const userDataDir = path.join(tempRoot, 'userData');
+  const backupRoot = path.join(userDataDir, '.dsa-desktop-update-backup');
+  const backupDbPath = path.join(backupRoot, 'data', 'stock_analysis.db');
+  fs.mkdirSync(path.dirname(backupDbPath), { recursive: true });
+  fs.mkdirSync(appDir, { recursive: true });
+  fs.writeFileSync(path.join(appDir, 'Uninstall Daily Stock Analysis.exe'), '');
+  fs.writeFileSync(backupDbPath, 'backup-db');
+  fs.writeFileSync(
+    path.join(backupRoot, 'runtime-state.json'),
+    JSON.stringify({ files: [path.join('data', 'stock_analysis.db')] }),
+    'utf-8'
+  );
+
+  const mainModule = loadMainModule(t, {
+    platform: 'win32',
+    app: {
+      isPackaged: true,
+      getPath: (name) => {
+        if (name === 'exe') {
+          return path.join(appDir, 'Daily Stock Analysis.exe');
+        }
+        return userDataDir;
+      },
+    },
+  });
+  const originalCopyFileSync = fs.copyFileSync;
+  let failedCopyAttempted = false;
+
+  fs.copyFileSync = (source, target) => {
+    if (source === backupDbPath) {
+      failedCopyAttempted = true;
+      throw new Error('target locked');
+    }
+    return originalCopyFileSync(source, target);
+  };
+
+  t.after(() => {
+    fs.copyFileSync = originalCopyFileSync;
+    fs.rmSync(tempRoot, { recursive: true, force: true });
+  });
+
+  assert.doesNotThrow(() => {
+    mainModule.restorePackagedRuntimeStateFromBackup();
+  });
+  assert.equal(failedCopyAttempted, true);
+  assert.equal(fs.existsSync(backupRoot), false);
+});
+
 test('stopBackend waits for backend process exit', async (t) => {
   const mainModule = loadMainModule(t);
   const killSignals = [];