feat: 支持 P1 Web 通知渠道一键测试 (#1200) - #1217
Closed
massif-01 wants to merge 3 commits into
Closed
Conversation
🤖 自动审查报告
📁 修改的文件
... 还有 10 个文件 🧠 AI 代码审查意见结论Ready to Merge 结构化审查结果
详细审查意见: 本次 PR 的质量非常高,从描述到代码实现细节都考虑得非常周全。
整体而言,这是一个准备充分、实现高质量的 PR。
|
Collaborator
Author
|
已用从 upstream/main 新建的 P1 专用分支重开:#1218。关闭这个旧 draft PR,避免保留冲突 head。 |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 类型
背景与问题
Issue #1200 的 P0 配置基线已通过 #1205 合入。本 PR 继续实现 P1:Web 设置页需要支持对单个通知渠道执行一键真实测试,测试应使用当前页面草稿值,不保存
.env,并返回成功/失败、耗时、错误摘要;自定义 Webhook 需要展示逐 URL attempts。具体改动
POST /api/v1/system/config/notification/test-channel与请求/响应 schema。SystemConfigService.test_notification_channel()中合成临时通知配置,并直接实例化目标 sender 发送测试消息。timeout_seconds参数,默认发送行为保持不变。test_custom_webhooks(),按 URL 顺序返回 attempts。NotificationTestPanel,接入渠道选择、标题、正文、timeout、结果和 attempts 展示。docs/notifications.md、docs/full-guide.md、docs/full-guide_EN.md和docs/CHANGELOG.md。关联 Issue
Refs #1200
验证命令与结果
关键输出/结论:
npm ci:执行成功;npm audit 报告依赖树中已有漏洞,但安装未失败。./scripts/ci_gate.sh:1731 passed, 2 deselected, 47 warnings, 139 subtests passed,backend gate 全部通过。npm run lint:通过。npm run build:通过;Vite 仍提示既有的大 chunk warning。npm run test -- ...:3 passed (3),26 passed (26)。git diff --check:通过。兼容性与风险
.env。回滚方案
回滚本 PR 即可。该功能不持久化测试请求,也不重写现有
.env,因此无需配置 migration 或数据回滚。EXTRACT_PROMPT 变更(如适用)
不适用。
展开:完整 EXTRACT_PROMPT
检查清单
docs/CHANGELOG.md;README.md仅在首页级信息变化时更新,细节优先写入docs/*.md/ If user-visible changes are included, relevant docs anddocs/CHANGELOG.mdare updated;README.mdis updated only for homepage-level changes, with details kept indocs/*.md