Skip to content

Remove market review from daily push notification - #1246

Closed
AaronShi32 wants to merge 5 commits into
ZhuLinsen:mainfrom
AaronShi32:remove-market-review-from-push
Closed

Remove market review from daily push notification#1246
AaronShi32 wants to merge 5 commits into
ZhuLinsen:mainfrom
AaronShi32:remove-market-review-from-push

Conversation

@AaronShi32

@AaronShi32 AaronShi32 commented May 9, 2026

Copy link
Copy Markdown

Summary

  • 每日推送通知和飞书云文档中移除「大盘复盘」内容,仅保留「决策仪表盘」
  • 飞书文档标题从"大盘复盘"改为"决策仪表盘"
  • 大盘复盘的生成逻辑保留,报告仍会保存到 reports/market_review_*.md,但完全不推送通知
  • run_market_reviewsend_notification 设为 False,确保无论合并/非合并模式都不推送

Test plan

  • 验证合并推送只包含决策仪表盘内容
  • 验证大盘复盘报告仍正常生成并保存
  • 验证大盘复盘不再推送通知(日志显示 已跳过推送通知
  • Docker 容器重建并运行 --force-run 验证通过

aoteman-mini and others added 5 commits May 1, 2026 08:31
- Add SearXNG as a compose service with JSON API enabled
- Split single analyzer into analyzer-pre (21:00) and analyzer-post (05:00)
  for US market pre-market and post-market analysis
- Remove deprecated `version` field from compose file
- Add health check and dependency chain (searxng -> analyzers/server)
- Add SearXNG as a compose service with JSON API enabled
- Split single analyzer into analyzer-pre (21:00) and analyzer-post (05:00)
  for US market pre-market and post-market analysis
- Remove deprecated `version` field from compose file
- Add health check and dependency chain (searxng -> analyzers/server)
feat(docker): add SearXNG and split pre/post market analyzers
Keep only the decision dashboard (决策仪表盘) in daily push
and Feishu doc, removing market review (大盘复盘) section.
The market review generation logic is preserved but no longer
included in the merged notification or Feishu document output.
@AaronShi32
AaronShi32 requested a review from ZhuLinsen as a code owner May 9, 2026 15:34
@github-actions github-actions Bot added ai documentation Improvements or additions to documentation size/M labels May 9, 2026
@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown

🤖 自动审查报告

项目 结果
📊 变更文件 3 个
➕ 新增行数 78 行
➖ 删除行数 29 行
🔍 静态检查 ✅ 通过
🧠 AI 审查 ✅ 已完成

📁 修改的文件

  • 📝 docker/docker-compose.yml (+61/-19)
  • 🆕 docker/searxng-settings.yml (+13/-0)
  • 📝 main.py (+4/-10)

💡 提示: 请确保代码已通过本地测试,并遵循项目代码规范。

@AaronShi32 AaronShi32 closed this May 9, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f03652815

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread main.py
# Issue #190: 合并推送(个股+大盘复盘
if merge_notification and (results or market_report) and not args.no_notify:
# Issue #190: 合并推送(仅决策仪表盘,不含大盘复盘
if merge_notification and results and not args.no_notify:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve market-review notification when no stock results

In merge mode (MERGE_EMAIL_NOTIFICATION=true), run_market_review intentionally skips its standalone push, expecting main.py to send a combined message later. This change now gates the combined send on results only, so executions that generate a valid market_report but no successful stock results (for example, empty STOCK_LIST or all stock analyses failing) produce no notification at all. Before this commit, the merged path still sent when market_report existed, so this is a regression in delivery behavior.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai documentation Improvements or additions to documentation size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant