Skip to content

chore: reorganize root files - #1257

Merged
ZhuLinsen merged 2 commits into
mainfrom
chore/reorganize-root-files
May 10, 2026
Merged

chore: reorganize root files#1257
ZhuLinsen merged 2 commits into
mainfrom
chore/reorganize-root-files

Conversation

@ZhuLinsen

@ZhuLinsen ZhuLinsen commented May 10, 2026

Copy link
Copy Markdown
Owner

What changed

  • Move documentation image/design assets from sources/ to docs/assets/ and update README / docs image links.
  • Move the Eastmoney request patch package from patch/ to src/patches/ and update data provider imports, Docker packaging, and CI smoke imports.
  • Move CI-only backend dependencies from requirements-ci.txt to .github/requirements-ci.txt and update CI / PR review references.
  • Move the skill-facing analyzer adapter from analyzer_service.py to src/services/analyzer_service.py and update SKILL.md examples.
  • Mark moved documentation assets as binary in .gitattributes so PR review diff decoding does not choke on binary/design files.
  • Add an [Unreleased] changelog entry for the repository-root cleanup.

Why

The repository root had accumulated implementation details, documentation assets, and CI-only files alongside the primary project entrypoints. This keeps the root focused on stable project-level files while preserving existing runtime behavior.

Impact

  • Runtime imports now use src.patches.eastmoney_patch instead of patch.eastmoney_patch.
  • Documentation image paths now point to docs/assets/.
  • CI installs backend gate dependencies via .github/requirements-ci.txt, which includes the root runtime requirements with -r ../requirements.txt.
  • GitHub PR review no longer tries to decode moved binary assets as UTF-8 diff content.

Validation

Local:

  • python -m py_compile src/services/analyzer_service.py data_provider/efinance_fetcher.py data_provider/akshare_fetcher.py src/patches/eastmoney_patch.py .github/scripts/ai_review.py
  • python -c "from src.services.analyzer_service import analyze_stock, analyze_stocks, perform_market_review; from src.patches.eastmoney_patch import eastmoney_patch; from data_provider.efinance_fetcher import EfinanceFetcher; from data_provider.akshare_fetcher import AkshareFetcher; print('moved imports ok')"
  • Checked .github/requirements-ci.txt resolves ../requirements.txt
  • python scripts/check_ai_assets.py
  • ./scripts/ci_gate.sh syntax
  • Verified PR-review-style git diff ... can be decoded with text=True

CI on PR #1257:

  • ai-governance: pass
  • backend-gate: pass
  • docker-build: pass
  • web-gate: skipped, no frontend changes
  • PR Review static check, AI review, review report, security check, and labels: pass

Rollback

Revert this PR to restore the previous root-level layout and import paths.

@ZhuLinsen
ZhuLinsen marked this pull request as ready for review May 10, 2026 11:31
Copilot AI review requested due to automatic review settings May 10, 2026 11:31
@github-actions

github-actions Bot commented May 10, 2026

Copy link
Copy Markdown

🤖 自动审查报告

项目 结果
📊 变更文件 30 个
➕ 新增行数 47 行
➖ 删除行数 28 行
🔍 静态检查 ✅ 通过
🧠 AI 审查 ✅ 已完成

📁 修改的文件

  • 📝 .gitattributes (+17/-0)
  • 📝 .github/requirements-ci.txt (+1/-1)
  • 📝 .github/scripts/ai_review.py (+2/-1)
  • 📝 .github/workflows/ci.yml (+3/-3)
  • 📝 .github/workflows/pr-review.yml (+2/-1)
  • 📝 README.md (+4/-4)
  • 📝 SKILL.md (+7/-7)
  • 📝 data_provider/akshare_fetcher.py (+1/-1)
  • 📝 data_provider/efinance_fetcher.py (+1/-1)
  • 📝 docker/Dockerfile (+0/-1)
  • 📝 docs/CHANGELOG.md (+1/-0)
  • 📝 docs/README_CHT.md (+4/-4)
  • 📝 docs/README_EN.md (+4/-4)
  • 📝 docs/assets/2026-01-10_155341_daily_analysis.gif (+0/-0)
  • 📝 docs/assets/alipay.jpg (+0/-0)
  • 📝 docs/assets/all_2026-01-13_221547.gif (+0/-0)
  • 📝 docs/assets/anspire.png (+0/-0)
  • 📝 docs/assets/config_backup_settings.png (+0/-0)
  • 📝 docs/assets/dapan_2026-01-13_22-14-52.png (+0/-0)
  • 📝 docs/assets/dsa_vi/banner.png (+0/-0)

... 还有 10 个文件


💡 提示: 请确保代码已通过本地测试,并遵循项目代码规范。

@ZhuLinsen ZhuLinsen left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

评审结论

  • 必要性:通过 + 根目录清理与 AGENTS.md 中目录边界、复用现有结构的要求一致。
  • 是否有对应 issue:无(PR 描述未检测到 Fixes/Closes/Refs 关联语句)。
  • PR 类型:chore + 主要是文件位置整理、导入路径更新、CI 依赖文件下移和资源路径同步。
  • description 完整性:完整 + 已说明变更范围、原因、影响、验证和 revert 级回滚方案。
  • 是否可直接合入:可 + 当前 CI 成功,未发现需要阻断合入的正确性或兼容性问题。

🤖 此回复由 OpenReview Bot 自动生成,仅供参考。如有疑问请 @维护者。

@ZhuLinsen
ZhuLinsen merged commit 595908c into main May 10, 2026
10 checks passed
@ZhuLinsen
ZhuLinsen removed the request for review from Copilot May 10, 2026 11:53
EchoingFootsteps pushed a commit to EchoingFootsteps/daily_stock_analysis that referenced this pull request Jul 4, 2026
* chore: reorganize root files

* fix: mark moved docs assets as binary
bmwu pushed a commit to bmwu/daily_stock_analysis that referenced this pull request Aug 24, 2026
* chore: reorganize root files

* fix: mark moved docs assets as binary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant