收口 Issue #1200 通知能力文档与 Actions 映射校验 P7 - #1276
Merged
ZhuLinsen merged 1 commit intoMay 13, 2026
Merged
Conversation
🤖 自动审查报告
📁 修改的文件
🧠 AI 代码审查意见结论: Ready to Merge 结构化审查结果:
必改项: 无。 建议项: 无。本次 PR 质量很高,文档清晰,逻辑严谨,自动化校验机制设计得当。
|
ZhuLinsen
reviewed
May 13, 2026
ZhuLinsen
left a comment
Owner
There was a problem hiding this comment.
评审结论
- 必要性:通过 + P7 收口通知专题文档,并把 Actions env 对照表纳入生成与校验,能降低文档和 workflow 映射漂移风险。
- 是否有对应 issue:有,Fixes #1200。
- PR 类型:docs/test + 主要是文档收口,同时新增生成脚本和静态测试保障文档一致性。
- description 完整性:完整 + 已说明背景、范围、兼容性、风险、验证命令与结果、回滚方案,并符合
AGENTS.md对文档变更和 changelog 的要求。 - 是否可直接合入:可 + 当前 CI 成功,改动范围集中在文档、生成脚本与测试,未发现行为/兼容性阻断点。
🤖 此回复由 OpenReview Bot 自动生成,仅供参考。如有疑问请 @维护者。
11 tasks
This comment was marked as resolved.
This comment was marked as resolved.
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
davidzhengdai
pushed a commit
to davidzhengdai/daily_stock_analysis
that referenced
this pull request
May 13, 2026
Anyone878
pushed a commit
to Anyone878/daily_stock_analysis
that referenced
this pull request
May 17, 2026
EchoingFootsteps
pushed a commit
to EchoingFootsteps/daily_stock_analysis
that referenced
this pull request
Jul 4, 2026
bmwu
pushed a commit
to bmwu/daily_stock_analysis
that referenced
this pull request
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Background And Problem
Issue #1200 已按阶段完成通知能力基线、Web 测试、Body 模板、路由、降噪、聚合报告失败隔离、ntfy / Gotify 一等渠道,以及 WebPush / Apprise 评估。
P7 是整个 issue 的收尾阶段:把通知专题文档补齐到本地 / Docker / GitHub Actions / Desktop 四类使用场景,并把 GitHub Actions 通知 env 对照表改成可自动生成和校验,避免后续 workflow env 与文档手写表格继续漂移。
本 PR 不新增运行时依赖、不新增配置项、不修改通知发送逻辑、不修改 API / Web schema / workflow env。
Scope Of Change
scripts/generate_notification_actions_env_table.pysrc.services.notification_diagnostics.KEY_SPECS读取通知 key 元数据。P0_ACTIONS_ENV_KEYS、P3_ROUTE_ENV_KEYS、P4_NOISE_ACTIONS_ENV_KEYS、P6_CHANNEL_ACTIONS_ENV_KEYS校验默认 daily workflow 必需映射。.github/workflows/daily_analysis.yml的执行股票分析stepenv:生成 GitHub Actions 通知 env 表。--write更新文档 marker 区块,支持--check检查文档是否漂移。docs/notifications.mdtests/test_daily_analysis_workflow_notification_env.pydocs/notifications.mdmarker 表格与脚本生成结果一致。docs/full-guide.md/docs/full-guide_EN.mddocs/CHANGELOG.md[Unreleased]增加扁平格式文档条目。Issue Link
Fixes #1200
Verification Commands And Results
python -m py_compile scripts/generate_notification_actions_env_table.py tests/test_daily_analysis_workflow_notification_env.py python scripts/generate_notification_actions_env_table.py --check python -m pytest tests/test_daily_analysis_workflow_notification_env.py tests/test_notification_diagnostics.py -q PATH=.venv/bin:$PATH ./scripts/ci_gate.sh git diff --check关键输出/结论:
py_compile:通过。generate_notification_actions_env_table.py --check:通过,文档表格与 workflow/env 元数据一致。22 passed。ci_gate.sh:1925 passed, 2 deselected, 42 warnings, 166 subtests passed,backend-gate: all checks passed。git diff --check:通过。Compatibility And Risk
兼容性影响:无运行时兼容性变化。本 PR 只改文档、生成脚本和文档一致性测试,不修改通知发送、配置加载、API、Web schema、workflow env 或默认行为。
风险:
.github/workflows/daily_analysis.yml中执行股票分析step 名称;如果后续 workflow 重命名该 step,--check和测试会明确失败,提示维护者同步脚本或 workflow。--check只校验通知相关 key 的 Actions 映射与文档表格一致,不会改变 workflow 行为。Rollback Plan
Revert this PR 即可回滚。无需数据迁移、配置清理或运行时回滚;如已在本地使用
--write更新文档,只需恢复docs/notifications.md对应 diff。EXTRACT_PROMPT Change (if applicable)
不适用。本 PR 未修改
src/services/image_stock_extractor.py或EXTRACT_PROMPT。展开 / Expand: Full EXTRACT_PROMPT
Checklist
docs/CHANGELOG.md;README.md仅在首页级信息变化时更新,细节优先写入docs/*.md/ If user-visible changes are included, relevant docs anddocs/CHANGELOG.mdare updated;README.mdis updated only for homepage-level changes, with details kept indocs/*.md