Closed
fix: address PR review feedback on LLM channel config#642
Conversation
Copilot
AI
changed the title
[WIP] [#544] Add multi-channel LLM configuration with WebUI editor
fix: address PR review feedback on LLM channel config
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four bugs identified in review of the multi-channel LLM config PR, covering false validation errors, incorrect model prefix canonicalization, swallowed error semantics, and a keyboard UX regression.
src/config.py— false positives invalidate_structured()Direct-env LiteLLM providers (
groq/*,bedrock/*, etc.) were being flagged as "not in channel model list" for primary, fallback, and vision models. Added_uses_direct_env_provider()guard to all three checks.api/v1/endpoints/system_config.py— error status ontest_llm_channelAll exceptions were returning
500 internal_error, making it impossible for the client to distinguish bad input from a backend fault.ValueError/TypeErrornow return422 validation_error; unexpected errors remain500.LLMChannelEditor.tsx— double-prefix on alias provider namesnormalizeModelForRuntime()would produceopenai/vertexai/gemini-proinstead ofvertex_ai/gemini-profor models with alias prefixes not inKNOWN_MODEL_PREFIXES. AddedPROTOCOL_ALIASEScanonicalization (vertexai→vertex_ai,claude→anthropic,google→gemini, etc.) applied before the prefix lookup:LLMChannelEditor.tsx— Space key scrolls page on channel headeronKeyDownwas missinge.preventDefault()for Space, causing the page to scroll when keyboard-navigating channel rows. Fixed.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.