ZCS-18232 : Remove zip and zipstore options from zimbraBackupDedupeCompressionType LDAP attribute. - #1770
ZCS-18232 : Remove zip and zipstore options from zimbraBackupDedupeCompressionType LDAP attribute.#1770Gopal-Moolchandani wants to merge 10 commits into
Conversation
5e253fb to
0f6c3a4
Compare
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 155).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.ParameterNameCheck> reported by reviewdog 🐶
Name 'ZimbraBackupCrossSessionDedupeEnabled' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 126).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 145).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.ParameterNameCheck> reported by reviewdog 🐶
Name 'ZimbraBackupCrossSessionDedupeEnabled' must match pattern '^[a-z][a-zA-Z0-9]*$'.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck> reported by reviewdog 🐶
Line exceeds 120 characters in comments
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 120 characters (found 126).
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.blocks.NeedBracesCheck> reported by reviewdog 🐶
'if' construct must use '{}'s.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.ConstantNameCheck> reported by reviewdog 🐶
Name 'A_ZimbraBackupCrossSessionDedupeEnabled' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
|
|
||
| ///// BEGIN-AUTO-GEN-REPLACE | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| * | ||
| * @since ZCS 10.1.14 | ||
| */ | ||
| @ZAttr(id=4149) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
| * | ||
| * @since ZCS 10.1.14 | ||
| */ | ||
| @ZAttr(id=4149) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
| return getBooleanAttr(Provisioning.A_ZimbraBackupCrossSessionDedupeEnabled, true, true); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| * | ||
| * @since ZCS 10.1.14 | ||
| */ | ||
| @ZAttr(id=4149) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
| return attrs; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck> reported by reviewdog 🐶
First sentence should end with a period.
| * | ||
| * @since ZCS 10.1.14 | ||
| */ | ||
| @ZAttr(id=4149) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not followed by whitespace.
| * | ||
| * @since ZCS 10.1.14 | ||
| */ | ||
| @ZAttr(id=4149) |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck> reported by reviewdog 🐶
'=' is not preceded with whitespace.
| */ | ||
| @ZAttr(id=4149) | ||
| public void unsetZimbraBackupCrossSessionDedupeEnabled() throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
| */ | ||
| @ZAttr(id=4149) | ||
| public void unsetZimbraBackupCrossSessionDedupeEnabled() throws com.zimbra.common.service.ServiceException { | ||
| HashMap<String,Object> attrs = new HashMap<String,Object>(); |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAfterCheck> reported by reviewdog 🐶
',' is not followed by whitespace.
d1a151b to
6fde25f
Compare
…it-tests pipeline (#1773) * Update build-common.xml * Update build-common.xml * ZCS-18299:Adding jacoco code-coverage for zm-mailbox/store,common,client,soap components * ZCS-18299:adding skipcoverage condition for coverage target
7a80f65 to
cb12f7e
Compare
Co-authored-by: Ron Straight <ron.straight@synacor.com>
…to windows clients (#1774) ZBUG-3974 updated license block ZBUG-3974 added logic to create timezone map dynamically from windows timezone information files ZBUG-3974 Modified file name
de2275d to
c7fe412
Compare
Added logic for Callback ZCS-18008 : Changed the since version to 10.1.14 ZCS-18232 : Remove zip and zipstore options from zimbraBackupDedupeCompressionType LDAP attribute. ZCS-18232 : Added ZimbraBackupCrossSessionDedupeEnabled attribute in LDAP attributes. Refactored according to modifications in requirement Modified the since version of new Backup LDAP attributes from 10.1.14 to 10.1.15 Changed the default value of ZimbraBackupCrossSessionDedupeEnabled to false Added the support for csd common backup Refactored Refactored the attribute name ZCS-18377 : Handle restore from CSD backups where CSD common backup is compressed and CSD delta backup is not compressed (or vice-versa) Modified the logic to remove cyclic dependency ZCS-18461: Unable to save or enabled dedupe and CSD backup together from admin console ZCS-18469 : Fixed backup creation with nocsd flag by adding it as a request parameter
a20f4c7 to
c5f8dfb
Compare
No description provided.