Skip to content

Fix _checks-golang - #33

Merged
lucaslopezf merged 13 commits into
mainfrom
fix/go-workflow
Jul 4, 2025
Merged

Fix _checks-golang#33
lucaslopezf merged 13 commits into
mainfrom
fix/go-workflow

Conversation

@lucaslopezf

@lucaslopezf lucaslopezf commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added support for optional GitHub App authentication in multiple workflows, enabling secure access to private repositories.
    • Introduced new workflow inputs for GitHub App credentials and repository configuration.
    • Enhanced Docker build process to securely pass GitHub App tokens as secrets when authentication is enabled.
  • Chores

    • Updated workflows to use a custom checkout action supporting GitHub App authentication.
    • Improved input handling and workflow parameterization for better flexibility.

@coderabbitai

coderabbitai Bot commented Jul 4, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

The workflows for Atlas migrations, Golang checks, and Cloud Run Docker builds were updated to support optional GitHub App authentication. New input parameters and secrets were introduced for GitHub App credentials. The standard checkout step was replaced by a custom action supporting GitHub App authentication, with conditional handling for Docker builds.

Changes

Files/Group Change Summary
.github/workflows/_atlas-migrations-reusable.yml,
.github/workflows/_cloud-run-build-docker.yml
Added inputs and secrets for GitHub App authentication; replaced checkout step with custom action supporting GitHub App credentials
.github/workflows/_cloud-run-build-docker.yml Updated Docker build step to conditionally use GitHub App token as a Docker secret; added cleanup for temporary token file
.github/workflows/_checks-golang.yaml Added goprivate input; passed to checkout action; updated checkout step with explicit ID and single-line input interpolation

Sequence Diagram(s)

sequenceDiagram
    participant Workflow
    participant CustomCheckout as checkout-with-app
    participant GitHub
    participant DockerBuild

    Workflow->>CustomCheckout: Invoke with (github_app_auth, github_app_repos, goprivate, app_id, app_pem)
    CustomCheckout->>GitHub: Authenticate (optionally via GitHub App)
    CustomCheckout-->>Workflow: Checkout code (with/without GitHub App token)
    alt Cloud Run Docker Build
        Workflow->>DockerBuild: Pass GitHub App token as secret (if enabled)
        DockerBuild->>GitHub: Use token for private repo access during build
        DockerBuild-->>Workflow: Build complete
        Workflow->>Workflow: Remove temporary token file
    end
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 32c62f3 and 89378b1.

📒 Files selected for processing (3)
  • .github/workflows/_atlas-migrations-reusable.yml (2 hunks)
  • .github/workflows/_checks-golang.yaml (2 hunks)
  • .github/workflows/_cloud-run-build-docker.yml (4 hunks)
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in a Comment
  • Commit Unit Tests in branch fix/go-workflow

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Allows the workflow to configure access to private Go modules.
It adds an input parameter `goprivate` to specify the module path prefixes.
It also configures Git to use the GitHub App token for authentication
when accessing private repositories.
Adds support for authenticating with a GitHub App to access private repositories.
This allows the workflow to checkout code and configure Git using the GitHub App's token,
enabling access to repositories without relying on user-specific credentials.

Also adds support for configuring GOPRIVATE environment variable.
Adds support for authenticating with a GitHub App to access private repositories during the build process.
This allows the workflow to clone private repositories and use their contents during the Docker image build.
It configures Git to use a GitHub App token for authentication and passes the token as a build argument.
@lucaslopezf
lucaslopezf marked this pull request as ready for review July 4, 2025 16:45
@lucaslopezf
lucaslopezf merged commit c6e5a4b into main Jul 4, 2025
1 of 2 checks passed
@lucaslopezf
lucaslopezf deleted the fix/go-workflow branch July 4, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant