Chore: UI optimization on User page#4752
Open
IgorA100 wants to merge 6 commits intoZoneMinder:masterfrom
Open
Conversation
- Added support for the "flex-col-X" class, where X can be 2 or 3. This is used in cases where, for example, we need to display a theoretical 3 columns, but 1 or 2 of them may not be displayed in certain cases. The remaining columns will then take up all available space. Can be used in conjunction with "col-md/lg-*", which will be placed inside "flex-col-X".
Contributor
Author
|
Done. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Classic skin’s User page layout to improve spacing/alignment and present permissions sections in a more responsive two-column layout.
Changes:
- Adjusts User page markup spacing (adds
mt-4, updates header padding classes). - Wraps Global + Group permissions sections in a two-column row layout (
flex-col-2). - Adds/updates CSS to refine fieldset/table spacing and user-page layout rules (including legend styling).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
web/skins/classic/views/user.php |
Tweaks layout/spacing and restructures permissions sections into a two-column row. |
web/skins/classic/css/base/views/user.css |
Adjusts fieldset/table spacing and removes legacy float-based layout for permissions. |
web/skins/classic/css/base/skin.css |
Adds legend styling and introduces .user-page-scoped layout helpers for the new flex-based layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ok. Let it be so, anyway, for now more than 3 pillars will not be used. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
I've made all the necessary corrections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
