Provide the user with up-to-date information about the supported version of audioMotionAnalyzer by IgorA100 · Pull Request #4753 · ZoneMinder/zoneminder

IgorA100 · 2026-04-25T20:54:07Z

When the user is in the Viewing tab on the Monitor page, we'll provide them with useful information about audioMotionAnalyzer (supported version number, download links, etc.).

This is necessary to determine whether we are using the analyzer, and if so, what version it is. We will then provide the user with useful information when they are in the Viewing tab.

- Now we only specify the supported analyzer version in one place in the audioMotionAnalyzer.js file - Added translations for three cases: when the analyzer is not installed, the wrong version is installed, or everything is fine.

IgorA100 · 2026-04-26T20:42:59Z

Done

Copilot

Pull request overview

Adds UI messaging on the Monitor “Viewing” tab to inform users whether the installed audioMotionAnalyzer matches the supported version, and provides install/update guidance.

Changes:

Adds a “WhatDisplayInfo” help text area under the “Show” selector on the Monitor Viewing tab and populates it via JS based on detected analyzer version.
Exposes new i18n strings for “OK / not installed / wrong version” messaging, plus version template substitution in the UI.
Loads the audioMotionAnalyzer module on the Monitor page and updates bundled help text to avoid hardcoding a specific CDN version.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
web/skins/classic/views/monitor.php	Adds `#WhatDisplayInfo` placeholder below the “Show” control.
web/skins/classic/views/js/monitor.js.php	Exports new translated strings to JS for version-status messaging.
web/skins/classic/views/js/monitor.js	Adds version-check logic and template replacement for display under “Show”.
web/skins/classic/js/audioMotionAnalyzer.js	Introduces supported-version constant and sets a global “current version” for UI consumption; adjusts custom element registration.
web/skins/classic/includes/functions.php	Ensures `audioMotionAnalyzer.js` is loaded on the Monitor page.
web/skins/classic/assets/audioMotion-analyzer/src/help.txt	Generalizes CDN URL instructions to not hardcode a specific version.
web/lang/ru_ru.php	Adds RU translations for analyzer version status messages; updates related help text.
web/lang/en_gb.php	Adds EN translations for analyzer version status messages; updates related help text.
web/includes/lang.php	Changes `translate()` to convert `~~` into `<br/>`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-29T02:45:23Z

 function translate($name) {
  global $SLANG;
  // The isset is more performant
  if ( isset($SLANG[$name]) || array_key_exists($name, $SLANG) )
-    return $SLANG[$name];
+    return preg_replace('/~~/', '<br/>', $SLANG[$name]);
  else
-    return $name;
+    return preg_replace('/~~/', '<br/>', $name);


This changes translate() to always replace ~~ with <br/>, which makes translate() return HTML markup rather than plain text. The existing pattern for handling ~~ line breaks is localized to option-help rendering (e.g., web/ajax/modals/optionhelp.php:21), so this global change can create inconsistent behavior in contexts that expect plain strings (JS alerts, placeholders, htmlspecialchars(translate(...)), etc.). Consider reverting this global behavior change and instead performing the ~~→<br/> conversion only at the specific render sites that use innerHTML (e.g., for the new audioMotion messages).

Copilot · 2026-04-29T02:45:23Z

+    'AudioMotionVersionNotInstalled' => 'Requires audio motion analyzer version "{AudioMotionVersionRequired}" to be installed~~Download link: https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired} or https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}',
+    'AudioMotionVersionWrongVersion' => 'The required analyzer version is "{AudioMotionVersionRequired}", but you have it installed "{AudioMotionVersionInstalled}"~~Download link: https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired} or https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}',


The message text says "Download link:" but the URLs are rendered as plain text (and then inserted via innerHTML), so they won’t be clickable links in most browsers. Consider rendering these as actual <a href=...> anchors (ideally created via DOM APIs rather than embedding raw HTML in translations) so they behave like real download links and are keyboard/screen-reader accessible.

Suggested change

'AudioMotionVersionNotInstalled' => 'Requires audio motion analyzer version "{AudioMotionVersionRequired}" to be installed~~Download link: https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired} or https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}',

'AudioMotionVersionWrongVersion' => 'The required analyzer version is "{AudioMotionVersionRequired}", but you have it installed "{AudioMotionVersionInstalled}"~~Download link: https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired} or https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}',

'AudioMotionVersionNotInstalled' => 'Requires audio motion analyzer version "{AudioMotionVersionRequired}" to be installed~~Download link: <a href="https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired}">https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired}</a> or <a href="https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}">https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}</a>',

'AudioMotionVersionWrongVersion' => 'The required analyzer version is "{AudioMotionVersionRequired}", but you have it installed "{AudioMotionVersionInstalled}"~~Download link: <a href="https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired}">https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired}</a> or <a href="https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}">https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}</a>',

Oh, my bad English :( Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

We check for the file's existence, and if it does, we set AUDIO_MOTION_ENABLED = true. Okay, let's do an additional check in case the import fails for some reason. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ON_ANALYZER_VERSION value (monitor.js) https://github.com/ZoneMinder/zoneminder/pull/4753/changes#r3158319956

…nalyzer.js)

IgorA100 · 2026-04-29T15:15:22Z

@connortechnology
I've made the necessary changes and left my comments.
I consider this PR project complete.

IgorA100 added 2 commits April 25, 2026 23:49

Upload audioMotionAnalyzer.js to the Monitor page (functions.php)

83f443c

This is necessary to determine whether we are using the analyzer, and if so, what version it is. We will then provide the user with useful information when they are in the Viewing tab.

- Added support for "~~" => <br/> for translation

446220c

- Now we only specify the supported analyzer version in one place in the audioMotionAnalyzer.js file - Added translations for three cases: when the analyzer is not installed, the wrong version is installed, or everything is fine.

IgorA100 marked this pull request as ready for review April 26, 2026 20:36

connortechnology requested a review from Copilot April 29, 2026 02:40

Copilot started reviewing on behalf of connortechnology April 29, 2026 02:41 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Update web/lang/en_gb.php

518ba21

Oh, my bad English :( Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

IgorA100 marked this pull request as draft April 29, 2026 13:16

IgorA100 and others added 3 commits April 29, 2026 17:27

Apply suggestion from @Copilot

f9df56c

We check for the file's existence, and if it does, we set AUDIO_MOTION_ENABLED = true. Okay, let's do an additional check in case the import fails for some reason. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Abort checkVerAudioMotion() if we couldn't get the CURRENT_AUDIO_MOTI…

8896bcf

…ON_ANALYZER_VERSION value (monitor.js) https://github.com/ZoneMinder/zoneminder/pull/4753/changes#r3158319956

customElements.define moved after the class declaration (audioMotionA…

db910df

…nalyzer.js)

IgorA100 marked this pull request as ready for review April 29, 2026 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Provide the user with up-to-date information about the supported version of audioMotionAnalyzer#4753

Provide the user with up-to-date information about the supported version of audioMotionAnalyzer#4753
IgorA100 wants to merge 6 commits intoZoneMinder:masterfrom
IgorA100:patch-546864

IgorA100 commented Apr 25, 2026 •

edited

Loading

Uh oh!

IgorA100 commented Apr 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 29, 2026

Uh oh!

Copilot AI Apr 29, 2026

Uh oh!

IgorA100 commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		'AudioMotionVersionNotInstalled' => 'Requires audio motion analyzer version "{AudioMotionVersionRequired}" to be installed~~Download link: https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired} or https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}',
		'AudioMotionVersionWrongVersion' => 'The required analyzer version is "{AudioMotionVersionRequired}", but you have it installed "{AudioMotionVersionInstalled}"~~Download link: https://cdn.jsdelivr.net/npm/audiomotion-analyzer@{AudioMotionVersionRequired} or https://github.com/hvianna/audioMotion-analyzer/releases/tag/{AudioMotionVersionRequired}',

Uh oh!

Conversation

IgorA100 commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IgorA100 commented Apr 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

IgorA100 commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IgorA100 commented Apr 25, 2026 •

edited

Loading