Remove write-through#6
Merged
Merged
Conversation
JesusMcCloud
reviewed
Jul 1, 2026
JesusMcCloud
left a comment
JesusMcCloud
left a comment
Contributor
There was a problem hiding this comment.
seems legit, but why compare Json instances?
Comment on lines
+43
to
+64
| private fun Json.hasSameConfigurationAs(other: Json): Boolean { | ||
| val left = configuration | ||
| val right = other.configuration | ||
| return left.encodeDefaults == right.encodeDefaults && | ||
| left.ignoreUnknownKeys == right.ignoreUnknownKeys && | ||
| left.isLenient == right.isLenient && | ||
| left.allowStructuredMapKeys == right.allowStructuredMapKeys && | ||
| left.prettyPrint == right.prettyPrint && | ||
| left.explicitNulls == right.explicitNulls && | ||
| left.prettyPrintIndent == right.prettyPrintIndent && | ||
| left.coerceInputValues == right.coerceInputValues && | ||
| left.useArrayPolymorphism == right.useArrayPolymorphism && | ||
| left.classDiscriminator == right.classDiscriminator && | ||
| left.allowSpecialFloatingPointValues == right.allowSpecialFloatingPointValues && | ||
| left.useAlternativeNames == right.useAlternativeNames && | ||
| left.namingStrategy == right.namingStrategy && | ||
| left.decodeEnumsCaseInsensitive == right.decodeEnumsCaseInsensitive && | ||
| left.allowTrailingComma == right.allowTrailingComma && | ||
| left.allowComments == right.allowComments && | ||
| left.classDiscriminatorMode == right.classDiscriminatorMode && | ||
| left.exceptionsWithDebugInfo == right.exceptionsWithDebugInfo | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
a StringFormat or JsonConfiguration is not a data class and thus uses referencial equality.
https://pl.kotl.in/vxGdhkoxK?theme=darcula
We could use .toString() for comparison instead
JesusMcCloud
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes write-through as it is not necessary for our usecase and makes integrations with kotlinx serialization more difficult. Also very unclear ownership relationship, can create mixed serial formats in same json object etc.