Skip to content

Release/1.0.0#19

Closed
JesusMcCloud wants to merge 2 commits into
developmentfrom
release/1.0.0
Closed

Release/1.0.0#19
JesusMcCloud wants to merge 2 commits into
developmentfrom
release/1.0.0

Conversation

@JesusMcCloud

@JesusMcCloud JesusMcCloud commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Discussion points:

  • Default Nonce Validation duration
  • Is there more potential to simplify APIs and remove old stuff/reduce API surface
  • Do we want multiple Makoto Constructors to ensure that at least iOS or Android is enabled, or do we just throw if both configs passed are null and expose the constructor with two nullable parameters?

TODOs:

  • Testing (see below)
  • Wait for info on SW roots and amend docs (and potentially code) accordingly
  • Full migration guide wrt. config changes and API changes
  • Docs and API docs proof reading
  • Social Previews for all pages
  • Exceptions
    • Check for exception annotations where required (constrructors)
    • In particular, re-evaluate configuration exception
    • Re-evaluate exception throws during initialisations
    • Make sure internal errors are really always bugs and always add a link to creating an issue to the message

Testing:

  • Test contracts (semantically, not Kotlin Contracts) and explicitly document implicit contracts/behaviour
    • Supreme Verifier constructor params propagate correctly to Makoto and nonce checker
    • Exception Mapping (Makoto Exceptions to AttestationResponse.Error)
  • KeyConstraints are observed correctly
  • CSR attributes and CSR extensions are correctly encoded
  • Auth prompts are correctly displayed

@JesusMcCloud
JesusMcCloud deleted the release/1.0.0 branch January 22, 2026 13:55
@JesusMcCloud
JesusMcCloud restored the release/1.0.0 branch January 22, 2026 13:56
@JesusMcCloud

Copy link
Copy Markdown
Contributor Author

superseded by #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant