docs: align v1 migration guide with proto - #2056
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the docs/whats-new-v1.md documentation to remove references to the createdAt and lastModified timestamp fields across Task and PushNotificationConfig objects. Additionally, it renames the event types taskStatusUpdate and taskArtifactUpdate to statusUpdate and artifactUpdate respectively in JSON examples, patterns, and TypeScript code snippets. There are no review comments to evaluate, so no further feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Verified this against the normative sources. The PR is correct on everything it changes and worth landing. There is one thing it leaves behind that belongs in the same fix, because it fails in exactly the same way. The changes here are rightAgainst
The PR is also right to leave the
Those two blocks are labelled v0.3.0:, and the What it leaves behind: those v0.3 examples carry the wrong
|
|
Hi @darrelmiller - this is a small update aligning the v1 migration guide with the current proto, all checks are green, and I'd greatly appreciate your review when you have a moment. Thank you! |
Description
The v1.0 migration guide still described stream wrappers and timestamp fields that do not exist in the normative
a2a.proto. A client copied from the guide would checktaskStatusUpdate/taskArtifactUpdate, while strict ProtoJSON emitsstatusUpdate/artifactUpdate, so conforming stream updates could be silently ignored. The guide also recommendedTask.createdAt,Task.lastModified, and push-notification configuration fields that the proto cannot serialize.This change aligns the v1.0 JSON and TypeScript examples with the canonical ProtoJSON member names, removes the nonexistent timestamp and
configIdclaims, preserves the validTaskStatus.timestampguidance, and leaves the intentional v0.3kindexamples unchanged.CONTRIBUTINGGuide.Fixes #2045 🦕