Skip to content

feat: Enable ITK tests - #403

Merged
bartek-gralewicz merged 22 commits into
epic/1.0_breaking_changesfrom
bgralewicz/enable_itk_tests
Apr 16, 2026
Merged

feat: Enable ITK tests#403
bartek-gralewicz merged 22 commits into
epic/1.0_breaking_changesfrom
bgralewicz/enable_itk_tests

Conversation

@bartek-gralewicz

@bartek-gralewicz bartek-gralewicz commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Description

Enable ITK tests.

Currently, the testing is done between the current a2a-js state and Go SDK 1.0 for the following configurations:

  • Streaming
    • JSON-RPC / gRPC
    • HTTP_JSON
  • Non-Streaming
    • JSON-RPC / gRPC
    • HTTP_JSON

Notes

At the moment, there is an extensive middle layer in itk_agent.ts. This middle layer is planned to be removed once ITK tests are less spec dependent and a2a-js is closer to 1.0 release state.

Fixes (partially) #321 🦕

@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

🧪 Code Coverage

⬇️ Download Full Report

Base PR Delta
src/client/factory.ts 95.45% 95.58% 🟢 +0.13%
src/client/transports/json_rpc_transport.ts 59.23% 59.06% 🔴 -0.17%
src/server/transports/jsonrpc/jsonrpc_transport_handler.ts 76.85% 72.31% 🔴 -4.54%
Total 82.9% 82.6% 🔴 -0.30%

Generated by coverage-comment.yml

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a shell script to automate the setup, testing, and cleanup of the ITK service using Docker. The review identified two main areas for improvement: making the path resolution more robust by using the script's directory instead of the current working directory, and enhancing the Python-based response parsing logic to use safer printing and provide better debugging information when JSON parsing fails.

Comment thread itk/run_itk.sh Outdated
Comment thread itk/run_itk.sh Outdated
@bartek-gralewicz
bartek-gralewicz marked this pull request as ready for review April 14, 2026 11:30
@bartek-gralewicz
bartek-gralewicz requested a review from a team as a code owner April 14, 2026 11:30
Comment thread src/client/transports/json_rpc_transport.ts Outdated
Comment thread src/server/transports/jsonrpc/jsonrpc_transport_handler.ts
@bartek-gralewicz
bartek-gralewicz merged commit d72a0a9 into epic/1.0_breaking_changes Apr 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants