Skip to content

fix: trim comments - #550

Merged
JakubWorek merged 2 commits into
epic/1.0_breaking_changesfrom
jakubworek/refactor-repo-docs
Jun 29, 2026
Merged

fix: trim comments#550
JakubWorek merged 2 commits into
epic/1.0_breaking_changesfrom
jakubworek/refactor-repo-docs

Conversation

@JakubWorek

@JakubWorek JakubWorek commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

Summary

Trimmed boilerplate comments across files

Fixes #490

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

🧪 Code Coverage

⬇️ Download Full Report

Base PR Delta
src/compat/v0_3/server/express/rest_handler.ts 72.04% 71.94% 🔴 -0.10%
src/compat/v0_3/translate/security.ts 98.32% 98.73% 🟢 +0.41%
Total 90.72% 90.73% 🟢 +0.01%

Generated by coverage-comment.yml

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the A2A SDK by streamlining documentation, simplifying code comments, and updating Genkit dependencies in the samples. It also adjusts version parsing to default empty or nullish inputs to the legacy '0.3' version. Key feedback suggests trimming version strings in isLegacyVersion to robustly handle whitespace-only inputs, and explicitly handling Date objects in the cleanEmpty utility of src/signature.ts to prevent them from being serialized as empty objects.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/version_utils.ts
Comment thread src/signature.ts

@bartek-gralewicz bartek-gralewicz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to split this PR into separate ones. The repo-wide doc/comment update should not include logic changes, such should be a separate PR.

I propose to keep this PR as doc-related and move logic changes to ->

  • Fixes as described in the PR description (if related, for unrelated it is recommended to do PR per fix)
  • Updates (version changes, etc)
  • Samples I would leave up to your judgement, whether these are under "fixes" scope or should have a separate PR as well.

Comment thread src/server/store.ts
Comment thread src/sse_utils.ts Outdated
@JakubWorek
JakubWorek force-pushed the jakubworek/refactor-repo-docs branch from bfe36b9 to d7135d8 Compare June 29, 2026 08:29
@JakubWorek JakubWorek changed the title fix: adjust src docs and samples to latest package, minor src and sample fixes fix: trim comments Jun 29, 2026
Comment thread src/server/express/rest_handler.ts
@JakubWorek
JakubWorek merged commit fbc049c into epic/1.0_breaking_changes Jun 29, 2026
9 checks passed
@JakubWorek
JakubWorek deleted the jakubworek/refactor-repo-docs branch June 29, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants