fix: trim comments - #550
Conversation
🧪 Code Coverage
Generated by coverage-comment.yml |
There was a problem hiding this comment.
Code Review
This pull request refactors the A2A SDK by streamlining documentation, simplifying code comments, and updating Genkit dependencies in the samples. It also adjusts version parsing to default empty or nullish inputs to the legacy '0.3' version. Key feedback suggests trimming version strings in isLegacyVersion to robustly handle whitespace-only inputs, and explicitly handling Date objects in the cleanEmpty utility of src/signature.ts to prevent them from being serialized as empty objects.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
bartek-gralewicz
left a comment
There was a problem hiding this comment.
I suggest to split this PR into separate ones. The repo-wide doc/comment update should not include logic changes, such should be a separate PR.
I propose to keep this PR as doc-related and move logic changes to ->
- Fixes as described in the PR description (if related, for unrelated it is recommended to do PR per fix)
- Updates (version changes, etc)
- Samples I would leave up to your judgement, whether these are under "fixes" scope or should have a separate PR as well.
bfe36b9 to
d7135d8
Compare
Description
Summary
Trimmed boilerplate comments across files
Fixes #490