Skip to content

fix: propagate executor errors directly to the caller instead of emitting synthetic failure tasks - #565

Closed
JakubWorek wants to merge 2 commits into
epic/1.0_breaking_changesfrom
jakubworek/align-messagesend-error-handling-to-other-sdks
Closed

fix: propagate executor errors directly to the caller instead of emitting synthetic failure tasks#565
JakubWorek wants to merge 2 commits into
epic/1.0_breaking_changesfrom
jakubworek/align-messagesend-error-handling-to-other-sdks

Conversation

@JakubWorek

Copy link
Copy Markdown
Contributor

Description

This PR aligns message/send error handling with other sdks by propagating the error instead of returning synthesized Task(FAILED). Streaming path is unchanged - synthesizing terminal failed status is correct there.

Fixes #370 🦕

@JakubWorek
JakubWorek requested a review from a team as a code owner July 6, 2026 08:32
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

🧪 Code Coverage

⬇️ Download Full Report

Base PR Delta
src/server/events/execution_event_queue.ts 94.44% 100% 🟢 +5.56%
src/server/request_handler/default_request_handler.ts 87.72% 88.46% 🟢 +0.74%
Total 90.65% 90.75% 🟢 +0.10%

Generated by coverage-comment.yml

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors error handling in DefaultRequestHandler by propagating executor rejections directly up to the caller's Promise instead of publishing a synthetic failed task. This simplifies the error handling logic in _runExecutor and updates the test suite to assert that errors are thrown. The review feedback suggests making the new onExecutorError callback parameter required rather than optional to improve type safety and eliminate unnecessary conditional checks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/server/request_handler/default_request_handler.ts
Comment thread src/server/request_handler/default_request_handler.ts Outdated
@JakubWorek JakubWorek closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant