fix: propagate executor errors directly to the caller instead of emitting synthetic failure tasks - #565
Conversation
…ting synthetic failure tasks
🧪 Code Coverage
Generated by coverage-comment.yml |
There was a problem hiding this comment.
Code Review
This pull request refactors error handling in DefaultRequestHandler by propagating executor rejections directly up to the caller's Promise instead of publishing a synthetic failed task. This simplifies the error handling logic in _runExecutor and updates the test suite to assert that errors are thrown. The review feedback suggests making the new onExecutorError callback parameter required rather than optional to improve type safety and eliminate unnecessary conditional checks.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Description
This PR aligns message/send error handling with other sdks by propagating the error instead of returning synthesized
Task(FAILED). Streaming path is unchanged - synthesizing terminal failed status is correct there.Fixes #370 🦕