build: enable strict mode in tsconfig - #577
Conversation
…oject-based tsc checks
🧪 Code CoverageNo coverage changes. Generated by coverage-comment.yml |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the betterer tool and replaces it with strict TypeScript type-checking, introducing a base TypeScript configuration (tsconfig.base.json) and a strict configuration for source files (tsconfig.src.json). The review feedback recommends swapping these configurations so that the default tsconfig.json is the strict configuration for src/ to improve IDE developer experience, while using a separate tsconfig.test.json for non-strict tests. This change also avoids redundant type-checking during linting, and the lint scripts in package.json should be updated accordingly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
ishymko
left a comment
ishymko
left a comment
There was a problem hiding this comment.
I actually agree with AI comments here, let's keep tsconfig.json strict and limit it to src and tck (as in the original betterer config, looks like tck is omitted now) and create a custom one for tests which is non-strict.
ishymko
changed the title
ishymko
left a comment
ishymko
left a comment
There was a problem hiding this comment.
nit: I changed PR prefix from feat to build as feat would be added into a changelog which is no-op for package consumers.
2 participants
Description
This PR removes betterer in favour of enabling strict mode in tsconfig for /src and base config based on previous one for other directories
Closes #182 🦕