fix: normalize legacy cards in createFromAgentCard - #602
Merged
JakubWorek merged 1 commit intoJul 27, 2026
Conversation
Signed-off-by: King Star <mcxin.y@gmail.com>
🧪 Code Coverage
Generated by coverage-comment.yml |
JakubWorek
approved these changes
Jul 27, 2026
bartek-gralewicz
pushed a commit
that referenced
this pull request
Jul 28, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.1](v1.0.0...v1.0.1) (2026-07-28) ### Bug Fixes * **compat/v0_3:** call context builder for compatibility layer ([#604](#604)) ([771836c](771836c)), closes [#600](#600) * normalize legacy cards in createFromAgentCard ([#602](#602)) ([9807a66](9807a66)), closes [#601](#601) * **signature:** canonicalize the same payload when signing and verifying ([#606](#606)) ([7415e0e](7415e0e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
ClientFactory.createFromAgentCard()selected transports directly fromsupportedInterfaces, while the URL path first normalized cards through theconfigured
AgentCardResolver. As a result, a pure v0.3 card with a top-levelurlstill failed withNo compatible transport foundeven when both documentedlegacy compatibility options were enabled.
Changes
This change exposes the default resolver's existing agent-card normalizer as an
optional resolver capability and applies it to direct-card creation before
transport selection. The URL path continues to consume the already-resolved
card without a second normalization pass. The normalized card is also passed to
the transport factory and retained by the returned client.
Compatibility remains opt-in: disabling resolver compatibility still rejects a
pure v0.3 card, and custom resolvers that only implement
resolve()keep theirexisting behavior. The compatibility guide now includes the custom-fetch plus
createFromAgentCard()workflow.Verification
npm run lint:ci npm run build npm run test-build npm test npm run test:edge npm run test:integrationCONTRIBUTINGGuide.Fixes #601