fix(signature): canonicalize the same payload when signing and verifying - #606
Merged
Merged
Conversation
🧪 Code Coverage
Generated by coverage-comment.yml |
bartek-gralewicz
approved these changes
Jul 28, 2026
bartek-gralewicz
pushed a commit
that referenced
this pull request
Jul 28, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.1](v1.0.0...v1.0.1) (2026-07-28) ### Bug Fixes * **compat/v0_3:** call context builder for compatibility layer ([#604](#604)) ([771836c](771836c)), closes [#600](#600) * normalize legacy cards in createFromAgentCard ([#602](#602)) ([9807a66](9807a66)), closes [#601](#601) * **signature:** canonicalize the same payload when signing and verifying ([#606](#606)) ([7415e0e](7415e0e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
generateAgentCardSignaturecanonicalized the card as supplied, whileverifyAgentCardSignaturecanonicalized the proto-normalized card. A cardcarrying an explicit protobuf default (e.g.
capabilities.extensions[].required: false) was therefore signed with that member present and verified with itabsent, so the SDK rejected a signature it had just generated.
Moved the
AgentCard.fromJSON/toJSONnormalization (and thesignaturesexclusion) into
canonicalizeAgentCard, so both paths share onecanonicalization. Matches the Python SDK, which has always used a single shared
_canonicalize_agent_card()helper.Fixes #605 🦕