Skip to content

fix: Add serialization for listTasks input/output parameters. - #610

Open
bartek-gralewicz wants to merge 1 commit into
mainfrom
bgralewicz/serialize_list_tasks_parameters
Open

fix: Add serialization for listTasks input/output parameters.#610
bartek-gralewicz wants to merge 1 commit into
mainfrom
bgralewicz/serialize_list_tasks_parameters

Conversation

@bartek-gralewicz

@bartek-gralewicz bartek-gralewicz commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

ProtoJSON omits default values while such are a required output for the listTasks method. This is present for both REST and JSON_RCP transports.

This PR fixes that by adding a list_tasks_serializer that makes sure that all fields are outputted, even if their values are default ones.

Fixes #609 🦕

@github-actions

Copy link
Copy Markdown

🧪 Code Coverage

⬇️ Download Full Report

Base PR Delta
src/server/express/rest_handler.ts 87.54% 87.78% 🟢 +0.24%
src/server/transports/jsonrpc/jsonrpc_transport_handler.ts 80% 83.58% 🟢 +3.58%
src/server/transports/rest/rest_transport_handler.ts 98.67% 98.69% 🟢 +0.02%
src/server/transports/list_tasks_serializer.ts (new) 92.85%
Total 90.9% 90.98% 🟢 +0.08%

Generated by coverage-comment.yml

@bartek-gralewicz bartek-gralewicz changed the title Add serialization for listTasks input/output parameters. fix: Add serialization for listTasks input/output parameters. Jul 30, 2026
@bartek-gralewicz
bartek-gralewicz marked this pull request as ready for review July 30, 2026 12:51
@bartek-gralewicz
bartek-gralewicz requested a review from a team as a code owner July 30, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ListTasks ProtoJSON serialization omits required empty pagination fields

1 participant