Closed
Conversation
Contributor
Forge Build Sizes
🔕 Unchanged
|
Contributor
♻️ Forge Gas SnapshotsSeems like you are not measuring gas of any operations yet. 🤔 |
DhairyaSethi
reviewed
Apr 9, 2026
| fs_permissions = [{ access = "read-write", path = "./reports" }, { access = "read-write", path = "./diffs" }] | ||
| ffi = true | ||
| evm_version = 'cancun' | ||
| gas_limit = 9223372036854775807 |
There was a problem hiding this comment.
this shouldn't be needed if we do the other more correct fix which is pause gas metering before running e2e tests and resume right after no?
| libs = ['lib'] | ||
| remappings = [] | ||
| fs_permissions = [{ access = "read-write", path = "./reports" }] | ||
| fs_permissions = [{ access = "read-write", path = "./reports" }, { access = "read-write", path = "./diffs" }] |
There was a problem hiding this comment.
we did this bc of time but now the snapshot diff to md logic can be moved to aave-helpers-js, like v3, instead of being in solidity. it has some reusability benefits bc it's used in seatbelt also
There was a problem hiding this comment.
and then the e2e test can just ffi
DhairyaSethi
reviewed
Apr 9, 2026
| GovV3Helpers.executePayload( | ||
| vm, | ||
| payload, | ||
| address(GovV3Helpers.getPayloadsController(ChainIds.MAINNET)) |
| console.log('--- E2E: Testing spoke %s ---', address(spokes[i])); | ||
| console.log('--------------------------------'); | ||
| e2eTestSpoke(spokes[i]); | ||
| e2eTestPositionManagers(spokes[i]); |
There was a problem hiding this comment.
i think we can avoid testing posms here or atleast put it behind another flag
|
Could you also add a |
Author
|
refer to #694 instead to help pick up megaeth RPC URL properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm changeset)