DroneFlightDAT#1428
Conversation
Update droneFlightLog.py
DroneFlightLog
|
@nopiadintya the path regex is too broad, it would probably bring in too many false positives. Is there a specific path (app path maybe) that these get saved? |
Im sory, You're right, Alexis. I'll narrow it down. For DJI Fly and DJI GO 4 on iOS, the logs are typically stored in the app's Documents folder. I will update the regex to something like: **/Documents/Logs/*.log specifically targeting the DJI app containers. |
|
@nopiadintya any update? |
|
@nopiadintya if you can share some sample file listings we can help build a better search pattern |
|
Thanks for the DJI drone log parser! Two things to fix before this can be merged:
Once those are addressed I'll re-review. Thanks! |
|
Hello sir, I sincerely apologize for the delayed response. I haven't been
able to reply sooner due to some health issues, and I've also been
experiencing technical issues with the device I'm using for this project. I
will address your feedback on the code as soon as I can. Thank you for your
patience, your understanding, and for reviewing the parser
…On Tue, Jun 23, 2026, 07:18 Brigs ***@***.***> wrote:
*abrignoni* left a comment (abrignoni/iLEAPP#1428)
<#1428 (comment)>
Thanks for the DJI drone log parser! Two things to fix before this can be
merged:
1.
Crash on no-data: droneFlightLog does return None when no entries are
parsed, but the @artifact_processor wrapper unpacks the return value (data_headers,
data_list, source_path = func(...)), so returning None raises TypeError:
cannot unpack non-iterable NoneType. Please return an empty result
instead, e.g. return data_headers, [], ''.
2.
Path glob too broad: paths: ("**/*.log",) matches every .log file
anywhere in the extraction, so the artifact opens and reads all of them on
every case. Please scope it to the DJI drone app's container/path (bundle
id or known DJI log directory) so it only runs on relevant files.
Once those are addressed I'll re-review. Thanks!
—
Reply to this email directly, view it on GitHub
<#1428?email_source=notifications&email_token=AOYQ2V7ID7IC2Q7XQXJUP6T5BHEFVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXGQZTGNRTGUZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4774336352>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOYQ2V35AJVEB5G4JYOJHX35BHEFVAVCNFSNUABFKJSXA33TNF2G64TZHMZDEOJYGQZDEOBTHNEXG43VMU5TGOBXGA3TCNRRGM42C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AOYQ2V3EFGMGKD2LYTLI5OD5BHEFVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXGQZTGNRTGUZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AOYQ2V4I3FVOKG3ZRHFJT635BHEFVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXGQZTGNRTGUZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
DroneFlightDAT-.DAT file parser