Skip to content

DroneFlightDAT#1428

Draft
nopiadintya wants to merge 4 commits into
abrignoni:mainfrom
nopiadintya:main
Draft

DroneFlightDAT#1428
nopiadintya wants to merge 4 commits into
abrignoni:mainfrom
nopiadintya:main

Conversation

@nopiadintya

Copy link
Copy Markdown

DroneFlightDAT-.DAT file parser

@stark4n6

Copy link
Copy Markdown
Collaborator

@nopiadintya the path regex is too broad, it would probably bring in too many false positives. Is there a specific path (app path maybe) that these get saved?

@nopiadintya

Copy link
Copy Markdown
Author

@nopiadintya the path regex is too broad, it would probably bring in too many false positives. Is there a specific path (app path maybe) that these get saved?

Im sory, You're right, Alexis. I'll narrow it down. For DJI Fly and DJI GO 4 on iOS, the logs are typically stored in the app's Documents folder. I will update the regex to something like: **/Documents/Logs/*.log specifically targeting the DJI app containers.

@stark4n6

Copy link
Copy Markdown
Collaborator

@nopiadintya any update?

@JamesHabben

Copy link
Copy Markdown
Collaborator

@nopiadintya if you can share some sample file listings we can help build a better search pattern

@JamesHabben JamesHabben added the question Further information is requested label Jun 18, 2026
@abrignoni

Copy link
Copy Markdown
Owner

Thanks for the DJI drone log parser! Two things to fix before this can be merged:

  1. Crash on no-data: droneFlightLog does return None when no entries are parsed, but the @artifact_processor wrapper unpacks the return value (data_headers, data_list, source_path = func(...)), so returning None raises TypeError: cannot unpack non-iterable NoneType. Please return an empty result instead, e.g. return data_headers, [], ''.

  2. Path glob too broad: paths: ("**/*.log",) matches every .log file anywhere in the extraction, so the artifact opens and reads all of them on every case. Please scope it to the DJI drone app's container/path (bundle id or known DJI log directory) so it only runs on relevant files.

Once those are addressed I'll re-review. Thanks!

@nopiadintya

nopiadintya commented Jun 23, 2026 via email

Copy link
Copy Markdown
Author

@JamesHabben JamesHabben marked this pull request as draft June 23, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants