NOISSUE - Update mGate version in http and ws adapters#2825
Merged
dborovcanin merged 5 commits intoabsmach:mainfrom Apr 25, 2025
Merged
NOISSUE - Update mGate version in http and ws adapters#2825dborovcanin merged 5 commits intoabsmach:mainfrom
dborovcanin merged 5 commits intoabsmach:mainfrom
Conversation
arvindh123
force-pushed
the
websocket_upgrade
branch
4 times, most recently
from
f2182c7 to
6c34ca8
Compare
Collaborator
|
@arvindh123 mGate PR has been merged. Please update the PR. |
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
arvindh123
force-pushed
the
websocket_upgrade
branch
from
9b326da to
c8fb4a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2825 +/- ##
==========================================
+ Coverage 27.53% 32.28% +4.74%
==========================================
Files 351 83 -268
Lines 55423 16245 -39178
==========================================
- Hits 15260 5244 -10016
+ Misses 39413 10732 -28681
+ Partials 750 269 -481 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Arvindh <arvindh91@gmail.com>
dborovcanin
requested changes
Apr 25, 2025
| } | ||
|
|
||
| responseHeader := http.Header{} | ||
| responseHeader.Set("X-SMQ-WS-Session-ID", sessionID) |
Collaborator
There was a problem hiding this comment.
Why do we use this custom header?
Contributor
Author
There was a problem hiding this comment.
To identify the WS client.
If two ws client uses same thing id (client id), then if any one disconnect , another will not get message
So to avoid it, we need unique id for each ws connection.
Signed-off-by: Arvindh <arvindh91@gmail.com>
dborovcanin
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes
Should be merged after https://github.com/absmach/mgate/pull/87