NOISSUE - Add pre authorization inteceptor for packet formatting#88
Merged
dborovcanin merged 3 commits intoabsmach:mainfrom Apr 21, 2025
Merged
NOISSUE - Add pre authorization inteceptor for packet formatting#88dborovcanin merged 3 commits intoabsmach:mainfrom
dborovcanin merged 3 commits intoabsmach:mainfrom
Conversation
arvindh123
requested changes
Apr 16, 2025
dborovcanin
reviewed
Apr 17, 2025
Contributor
dborovcanin
left a comment
There was a problem hiding this comment.
Pre- and post- are tricky if we don't know what they are referring to. Something like beforeHandler and afterHandler would be more self-documenting.
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
eddb339 to
1db3156
Compare
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
a053f59 to
79b969e
Compare
dborovcanin
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
This pr adds an inteceptor before authorization to allow for packet formatting.
Which issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes