fix(ci): the preview gate skips cancelled runs - #1079
Open
dot-agi wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dot-agi
dismissed
cursor[bot]’s stale review
August 4, 2026 23:31
The merge-base changed after approval.
dot-agi
force-pushed
the
fix/preview-gate-cancelled-runs
branch
from
August 6, 2026 07:29
9a37e60 to
fa70a1f
Compare
Contributor
Oddish previewCommit:
Vercel deployment URL: https://oddish-7k88e3e16.oddish.app Plan:
This comment is updated by the PR Preview workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
The preview gate failed in runs that GitHub cancelled. This pull request makes the gate skip those runs. The gate then reports only from the run that continues.
Problem
always()condition. That condition made the gate run in the cancelled run also.Change
always()!cancelled()Validation
The replacement run for #1023 was successful. The gate in that run was successful. The pull request became mergeable with no manual step. Only the cancelled run made the failing check. This change prevents that false failure.
Note
Low Risk
Single workflow condition change in CI gating only; behavior for successful and skipped-dependency paths is intentionally preserved.
Overview
Require working preview no longer runs when the workflow run itself was cancelled (e.g. superseded by
cancel-in-progresson rapid pushes). The jobifchanges fromalways()to!cancelled(), so obsolete runs stop posting a failing required check and Preview deployment status while the newer run is still building.Fork and promotion paths are unchanged: the gate still runs when upstream jobs are skipped, which
!cancelled()allows but a stricter success-only condition would not.Reviewed by Cursor Bugbot for commit fa70a1f. Bugbot is set up for automated code reviews on this repo. Configure here.