Skip to content

fix(ci): the preview gate skips cancelled runs - #1079

Open
dot-agi wants to merge 1 commit into
stagingfrom
fix/preview-gate-cancelled-runs
Open

fix(ci): the preview gate skips cancelled runs#1079
dot-agi wants to merge 1 commit into
stagingfrom
fix/preview-gate-cancelled-runs

Conversation

@dot-agi

@dot-agi dot-agi commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

The preview gate failed in runs that GitHub cancelled. This pull request makes the gate skip those runs. The gate then reports only from the run that continues.

Problem

  1. A user pushes two commits in a short time. Each push starts a preview run.
  2. The concurrency group cancels the first run.
  3. The gate job had the always() condition. That condition made the gate run in the cancelled run also.
  4. The dependencies of the gate were cancelled. The gate failed.
  5. The pull request showed a failing required check. The replacement run was not complete at that time. Pull request new taxonomy #1023 showed this problem on 2026-08-05.

Change

Item Before After
Gate condition always() !cancelled()
Run with skipped dependencies (fork and promotion paths) The gate runs The gate runs (no change)
Cancelled run The gate fails and reports a failure The gate does not run. Only the replacement run reports.

Validation

The replacement run for #1023 was successful. The gate in that run was successful. The pull request became mergeable with no manual step. Only the cancelled run made the failing check. This change prevents that false failure.


Note

Low Risk
Single workflow condition change in CI gating only; behavior for successful and skipped-dependency paths is intentionally preserved.

Overview
Require working preview no longer runs when the workflow run itself was cancelled (e.g. superseded by cancel-in-progress on rapid pushes). The job if changes from always() to !cancelled(), so obsolete runs stop posting a failing required check and Preview deployment status while the newer run is still building.

Fork and promotion paths are unchanged: the gate still runs when upstream jobs are skipped, which !cancelled() allows but a stricter success-only condition would not.

Reviewed by Cursor Bugbot for commit fa70a1f. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
oddish-app Ready Ready Preview Aug 6, 2026 7:37am

cursor[bot]
cursor Bot previously approved these changes Aug 4, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Approved — Cursor Bugbot passed with no findings requiring human review; Cursor Security Agent was not present. No additional reviewers assigned (two already requested).

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@dot-agi
dot-agi force-pushed the fix/preview-gate-cancelled-runs branch from 9a37e60 to fa70a1f Compare August 6, 2026 07:29
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Oddish preview

Commit: fa70a1f1cda1e924c231e7d242059b656c8170c6

Surface Link Target
Frontend https://pr-1079.oddish.app Vercel preview for fa70a1f
Backend oddish-pr-1079 oddish-pr-1079
Database project ijsgdozgohsvvxgscixg project ijsgdozgohsvvxgscixg

Vercel deployment URL: https://oddish-7k88e3e16.oddish.app

Plan:

  • Frontend deploy: true
  • Backend deploy: true
  • Migrations: true

This comment is updated by the PR Preview workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant