revert(ui): restore previous QA trial display - #1146
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Oddish previewCommit:
Vercel deployment URL: https://oddish-mcpj91pqi.oddish.app Plan:
This comment is updated by the PR Preview workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Safety
pnpm lintpnpm exec tsc --noEmitpnpm buildpnpm test:e2e(13 passed, 5 credential-dependent tests skipped)Note
Low Risk
Presentation-only revert of frontend trial/QA visualization; no API or data-model changes.
Overview
Reverts the QA trial-glyph UI from #1140 so trial outcome and QA are visually separate again.
Matrix cells and the trial navigator use outcome-colored tiles (
pass/failstyling fromSTATUS_CONFIG) with ✓/✗ for execution result. QA is shown only via the corner dot (and tooltips), not by recoloring the glyph for classifications like good failure or bad success.status-config.tsdrops the shared QA-tone helpers (getVisibleAnalysisClassification,getQaGlyphMatrixClass,QA_TONE_MATRIX_CLASS, classification labels). The legend goes back to simple colored dots for QA (Pass / Fail instead of Good/Bad), a single sample cell with a QA dot, and shorter “trial result” / “QA result” copy instead of shape-vs-color semantics.Reviewed by Cursor Bugbot for commit ba4d472. Bugbot is set up for automated code reviews on this repo. Configure here.