Skip to content

revert(ui): restore previous QA trial display - #1146

Merged
kyle-compute merged 1 commit into
stagingfrom
fix/trial-classification-color-pass-rate
Aug 11, 2026
Merged

revert(ui): restore previous QA trial display#1146
kyle-compute merged 1 commit into
stagingfrom
fix/trial-classification-color-pass-rate

Conversation

@kyle-compute

@kyle-compute kyle-compute commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • revert only the QA trial-glyph/classification UI from feat(ui): show expected good failures as a green ✗ #1140
  • restore outcome-colored matrix cells with QA classification shown as the previous corner-dot treatment
  • restore the previous trial navigator and legend behavior
  • preserve every other change currently on staging

Safety


Note

Low Risk
Presentation-only revert of frontend trial/QA visualization; no API or data-model changes.

Overview
Reverts the QA trial-glyph UI from #1140 so trial outcome and QA are visually separate again.

Matrix cells and the trial navigator use outcome-colored tiles (pass/fail styling from STATUS_CONFIG) with ✓/✗ for execution result. QA is shown only via the corner dot (and tooltips), not by recoloring the glyph for classifications like good failure or bad success.

status-config.ts drops the shared QA-tone helpers (getVisibleAnalysisClassification, getQaGlyphMatrixClass, QA_TONE_MATRIX_CLASS, classification labels). The legend goes back to simple colored dots for QA (Pass / Fail instead of Good/Bad), a single sample cell with a QA dot, and shorter “trial result” / “QA result” copy instead of shape-vs-color semantics.

Reviewed by Cursor Bugbot for commit ba4d472. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
oddish-app Ready Ready Preview Aug 11, 2026 12:15am

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Approved — Cursor Bugbot passed with no findings requiring human review; Cursor Security Agent was not present. No reviewers assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@github-actions

Copy link
Copy Markdown
Contributor

Oddish preview

Commit: ba4d472b71ec3903096f33e15c674fc70c57b2cb

Surface Link Target
Frontend https://pr-1146.oddish.app Vercel preview for ba4d472
Backend staging staging
Database staging branch staging branch

Vercel deployment URL: https://oddish-mcpj91pqi.oddish.app

Plan:

  • Frontend deploy: true
  • Backend deploy: false
  • Migrations: false

This comment is updated by the PR Preview workflow.

@kyle-compute
kyle-compute merged commit 6146f65 into staging Aug 11, 2026
17 checks passed
@kyle-compute
kyle-compute deleted the fix/trial-classification-color-pass-rate branch August 11, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant