perf(tasks): maintain task browse summaries on trial writes - #1185
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Oddish previewCommit:
Vercel deployment URL: https://oddish-7goxerv0n.oddish.app Plan:
This comment is updated by the PR Preview workflow. |
This was referenced Aug 11, 2026
One summary row per task version (exact card counters, status buckets, model-grouped cost inputs, last_run_at), refreshed inside the same transaction as every trial-population mutation: create/import, start/reset, completion, cancellation, retry/supersede, scoped deletion, experiment deletion, and default-version selection. Refreshes serialize per version with sorted transaction-scoped advisory locks because concurrent trial inserts hold KEY SHARE FK locks on task_versions. No reader change and no historical scan: the browse endpoint still aggregates on demand, and rows exist only for versions written to after deploy. The read cutover and historical population land separately. Split 1/4 of the #1152 re-land.
kyle-compute
force-pushed
the
perf/tasks-browse-last-activity
branch
from
August 12, 2026 00:28
514a235 to
bf1223b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bf1223b. Configure here.
This was referenced Aug 12, 2026
pfbyjy
pushed a commit
that referenced
this pull request
Aug 12, 2026
Four tests broke against code that arrived from staging, not against this branch's changes: the browse-summary refresh (#1185) added a (id, task_version_id) select and an advisory-lock execute that the deletion and task-detail fakes did not model, the ephemeral Harbor runner grew a required environment_config argument, and the cleanup sweep test still patched the deleted _reset_orphaned_trial_analysis. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GzxfgtotWcStMXaRAkvotj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why this PR exists
Split structure and merge order
Exact screen, request, and frequency
Production evidence
What this PR changes
Why this is being re-landed
What this PR does not change
Historical-data decision
Validation completed
Rollback