Conversation
…1267) Co-authored-by: Claude <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
/promote |
Contributor
|
Promoted. main now points at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
DO NOT USE THE MERGE BUTTON ON THIS PULL REQUEST.
THE BUTTON CREATES A NEW COMMIT AND BREAKS THE RELEASE MODEL.
COMMENT
/promoteTO COMPLETE THE PROMOTION.Summary
Ships the follow-up that makes the
opencodeGoogle credential fix actually reachable: the platform key is now mirrored ontoGOOGLE_GENERATIVE_AI_API_KEYin the worker'sos.environ, which is the surface Harbor's opencode agent reads when choosing provider keys to forward.Commits in this promotion
One commit.
mainis an ancestor ofstaging(git merge-base --is-ancestorpasses), so this fast-forwards cleanly.Validation
Staging Deployto go green ona406827before commenting/promote. At the time of writing it is still in progress, along withload_only Guard,E2E: CLI smokeandE2E: Dashboard.Branch Sync Guardhas already passed. Promotion Preflight re-checks the staging deploy, so an early/promotefails safe rather than shipping unvalidated code.PR #1267 ran
uv run pytest tests/test_harbor_runner.py tests/test_job_tokens.py→ 162 passed. The two failures in that file (test_restricted_cursor_gets_transport_hosts_and_web_hardening,test_run_harbor_trial_async_skips_temp_root_preflight_without_task_patch) are pre-existing onmain— verified by checking out cleanmainwithout the commit and re-running, where they fail identically.Not soak-tested beyond the automated deploy. The behaviour it fixes can only be exercised by a real
opencode+google/trial, which is the follow-up below.Follow-up
Once deployed, re-run 2–3
opencodetrials in826d7d88and confirm input tokens climb above zero — that is the proof the credential reaches the CLI. The prior 160 trials are zero-token infra failures with no salvageable signal and can be deleted.Independently worth doing: add
GOOGLE_GENERATIVE_AI_API_KEYto theoddish-prodModal secret. This commit makes the platform resilient without it, but an explicit secret is authoritative and this code deliberately never overwrites one.Generated by Claude Code