Centralize Harbor pin and sync backend workers to dsh revision - #1286
Draft
RishiDesai wants to merge 1 commit into
Draft
Centralize Harbor pin and sync backend workers to dsh revision#1286RishiDesai wants to merge 1 commit into
RishiDesai wants to merge 1 commit into
Conversation
Add oddish/src/oddish/harbor-pin.toml as the single source of truth for the locked abundant-ai/harbor revision, load it from config at runtime, and add a sync script plus CI guard so backend/pyproject.toml cannot drift from oddish again. Bump production workers to 078136c5, which includes the dsh agent. Co-authored-by: rishi <rishi@abundant.ai>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Oddish previewCommit:
Vercel deployment URL: https://oddish-qptqdm8u3.oddish.app Plan:
This comment is updated by the PR Preview workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production workers were still building Harbor from
ca4fda6, which does not include thedshagent, even after PR #1256 promoted Oddish routing tomain. That PR bumped onlyoddish/pyproject.toml, whilebackend/pyproject.toml(the image the Modal workers actually build from) was left behind.This PR fixes that drift and makes the pin harder to split again:
oddish/src/oddish/harbor-pin.tomlas the single source of truth for the lockedabundant-ai/harborrevisionHARBOR_DEFAULT_SOURCE/HARBOR_DEFAULT_SHAfrom that file at runtimeoddish/scripts/sync_harbor_pin.pyto propagate the pin into bothoddish/pyproject.tomlandbackend/pyproject.toml.github/workflows/harbor-pin-guard.yml) that fails if either pyproject drifts fromharbor-pin.toml078136c5(Harbor PR merge pending into queued on the FE #27: DeepSeek Harness /dshagent) and regeneratesbackend/uv.lockWhy a separate pin file?
backend/pyproject.tomlcannot inherit[tool.uv.sources]from the transitiveoddishdependency because Modal worker images are built directly from the backend project. The pin must be duplicated in both pyproject files, but only edited in one place (harbor-pin.toml).Test plan
uv run python scripts/sync_harbor_pin.py --checkuv run pytest tests/test_harbor_spec_parse.py078136c5on workersdsh+fireworks/deepseek-v4-pro-0813smoke trial on prod