Skip to content

Partial Revert "Fix correlation on A100 CUTLASS GEMM Kernels (#127)" - #133

Merged
JRPan merged 3 commits into
accel-sim:devfrom
purdue-aalp:partial-revert-issue-block2core
Jan 22, 2026
Merged

Partial Revert "Fix correlation on A100 CUTLASS GEMM Kernels (#127)"#133
JRPan merged 3 commits into
accel-sim:devfrom
purdue-aalp:partial-revert-issue-block2core

Conversation

@JRPan

@JRPan JRPan commented Jan 21, 2026

Copy link
Copy Markdown

Summary

  • Reverts the kernel issue (CTA scheduling) part of commit 987a23f
  • Removes the pending_ctas queue mechanism from issue_block2core
  • Removes allocated_ctas tracking from kernel_info_t
  • Restores the original CTA scheduling behavior

This partial revert only affects the issue_block2core function and related data structures. The Perfect xbar interconnect changes from the original commit are not reverted.

Test plan

  • Verify CTA scheduling works correctly with the reverted code
  • Run correlation tests to ensure expected behavior

🤖 Generated with Claude Code

close accel-sim/accel-sim-framework#528
close accel-sim/accel-sim-framework#526

JRPan and others added 2 commits January 20, 2026 20:34
…im#127)"

This reverts commit 987a23f.

Only reverting the kernel issue part - issue_block2core.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace C-style arrays with std::array for type safety
- Add zero-initialization using {} for arrays
- Add explicit zero-initialization for scalar latency variables
- Add #include <array> header

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@JRPan
JRPan requested a review from William-An January 22, 2026 17:43
@JRPan

JRPan commented Jan 22, 2026

Copy link
Copy Markdown
Author

Added commit to modernize latency array declarations with C++17 style:

  • Replaced C-style arrays (unsigned int_latency[6], etc.) with std::array for type safety and bounds checking
  • Added zero-initialization using {} for arrays to ensure all elements start at 0
  • Added explicit = 0 initialization for scalar latency variables (sfu_latency, tensor_latency)
  • Added #include <array> header

@JRPan
JRPan merged commit 6c3cf4f into accel-sim:dev Jan 22, 2026
15 checks passed
@JRPan
JRPan deleted the partial-revert-issue-block2core branch January 22, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Out of bound access on initializing integer pipeline Missing kernel uid and name during stat print

1 participant