Guard pipelined_simd_unit against initiation_interval > latency - #139
Open
AndrewVu23 wants to merge 1 commit into
Open
Guard pipelined_simd_unit against initiation_interval > latency#139AndrewVu23 wants to merge 1 commit into
AndrewVu23 wants to merge 1 commit into
Conversation
Author
|
Just went through the issues and apparently, I'm not the only one who has this problem: accel-sim/gpu-app-collection#75 (comment) |
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents a memory-corrupting out-of-bounds access when a functional unit is configured with initiation_interval > latency. Turns a wild SIGSEGV into a bounded first-stage placement.
Motivation / root cause
After adding
gpgpusim.config&trace.configand running the sim for RTX 3060, the tests for FP64 failed. I digged deeper into thetrace.configand saw this:Those 2 numbers in
-trace_opcode_latency_initiation_dpretrun their values tolatencyandinitiation_intervalinshader.ccWith
start_stage(or index) at-9, the run crashes.Changes
shader.cc: if (start_stage < 0) start_stage = 0; before the pipeline-reg accessLimitations / known gaps
init>latencythe run instead hits a register_set:No free registers assertion, which is not handled by the sim. In order to passsegfaultwhile running FP64, I had to change the values manually (make them equal). Also, after further checking, RTX 2060 & 3070 configs in the sim also has 64, 64 (just like mine after manually fixing).max(latency, init)