Skip to content

chore(*): update codegen for Concerto v4 compatibility#215

Merged
jamieshorten merged 3 commits intoaccordproject:mainfrom
muhabdulkadir:moh/codegen-v4
Apr 28, 2026
Merged

chore(*): update codegen for Concerto v4 compatibility#215
jamieshorten merged 3 commits intoaccordproject:mainfrom
muhabdulkadir:moh/codegen-v4

Conversation

@muhabdulkadir
Copy link
Copy Markdown
Contributor

@muhabdulkadir muhabdulkadir commented Apr 28, 2026

Closes #

Concerto v4 Compatibility Update for Codegen

This PR updates concerto-codegen to work with Concerto Core v4.

Key Changes

  • Namespace Versioning: All test models now use versioned namespaces
  • Removed Unversioned Test: Removed test for unversioned namespaces (no longer supported in v4)
  • Protobuf Test Refactor: Replaced remote model loading with local minimal models to avoid v3 compatibility conflicts
  • TypeScript Unions: Updated to use serializer-based validation instead of the deprecated Concerto constructor
  • Snapshot Updates: Regenerated all snapshots reflecting versioned namespace outputs
  • Dependency Change: Moved Concerto dependencies to peerDependencies (v4 compatibility)

Breaking Changes

This is a v4 major version bump. Code using these packages must:

  1. Update all model namespaces to versioned format
  2. Declare concerto version "^4.0.0" or compatible version
  3. Update imports to reference versioned namespaces

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: muhammed-abdulkadir <muhammed.abdulkadir@docusign.com>
Signed-off-by: muhammed-abdulkadir <muhammed.abdulkadir@docusign.com>
Signed-off-by: muhammed-abdulkadir <muhammed.abdulkadir@docusign.com>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we deleting these?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 enforces strict mode, so unversioned models are no longer compatible.

@jamieshorten jamieshorten merged commit 4827ce8 into accordproject:main Apr 28, 2026
11 checks passed
@muhabdulkadir muhabdulkadir deleted the moh/codegen-v4 branch April 28, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants