Build initial RSVP frontend - #1
Merged
Merged
Conversation
Deploying with Cloudflare Pages
|
…better data loading
…into fix-rsvp-frontend
…into fix-rsvp-frontend
devksingh4
suggested changes
Mar 6, 2026
devksingh4
left a comment
devksingh4
left a comment
Contributor
There was a problem hiding this comment.
General things:
this error should NOT be shown if the user is just pending enrollment. Also, the mailto doesn't seem to work for me
Website title, etc not set
You should use the files from here: https://github.com/acm-uiuc/website/tree/main/public and put them in the public for RSVP, changing strings as necessary. Do not need the _redirects file.
devksingh4
suggested changes
Mar 18, 2026
devksingh4
left a comment
devksingh4
left a comment
Contributor
There was a problem hiding this comment.
We should add tests but other than this and the notification on profile creation, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.