Skip to content

Update world.h#198

Open
asmanel wants to merge 1 commit into
acreloaded:mainfrom
asmanel:asmanel-patch-1
Open

Update world.h#198
asmanel wants to merge 1 commit into
acreloaded:mainfrom
asmanel:asmanel-patch-1

Conversation

@asmanel

@asmanel asmanel commented Apr 13, 2016

Copy link
Copy Markdown

pCube maps glitch fix

Comment thread source/src/world.h
} \
} \
if(headr.version>=6 && headr.version<8) { \
if(strncmp(headr.head,"CUBE",4)==1 && (headr.version>=6 && headr.version<8)) { \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing the result of strncmp to 1 is unreliable.

@theonlypwner

theonlypwner commented Apr 14, 2016

Copy link
Copy Markdown
Member

I have added a link to the pCube project in the first post.

You mentioned that pCube maps have a version number of 6 and "CUBE" magic bytes and old AC v6 maps have "ACMP" magic.

If that's the cause, replacing 6 with 7 in the first and last changed lines should fix the problem.

@theonlypwner theonlypwner force-pushed the master branch 9 times, most recently from fbaff05 to 06cc372 Compare December 5, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants