feat(rnd-dialog): Add drag constraints support for dialog + OnPush optimization#2
Open
RaimonxDev wants to merge 1 commit intoacrodata:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A drag constraint system was implemented to control the movement boundaries of the dialog:
• RndDialogDragConstraints Interface: Defines individual constraints for each direction (top, right, bottom, left).
• Flexible Configuration: Constraints can be passed through the dialog’s data.
OnPush change detection was applied to improve performance.
To avoid interfering with or creating a new method for configuring the modal, the drag constraints were added via the data property.
If you think there’s a better approach, feel free to suggest changes.
I hope it will be useful