zod secret mixin#41
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Zod secret mixin that enables marking sensitive fields in Zod schemas as secret, ensuring that such fields are redacted from logs. Key changes include:
- Adding a new utility in backend/util/zodSecretsMixin.ts that augments Zod types with a .secret() method.
- Updating action input schemas in user and session actions to utilize the new .secret() mixin.
- Integrating secret field handling in the connection sanitization logic and adding documentation and tests to support these changes.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/.prettierignore | Added "types/" to be ignored by Prettier |
| backend/util/zodSecretsMixin.ts | New file implementing the secret mixin for various Zod types, enabling secret field marking |
| backend/util/formatters.ts | Removal of formatting utility functions; ensure this change is intentional and dependencies updated |
| backend/classes/Connection.ts | Integrated secret field detection in request sanitization |
| backend/actions/user.ts and session.ts | Updated password fields to apply the secret mixin |
| backend/tests/actions/user.test.ts | Added test case to verify that secret fields are redacted in logging |
| backend/.prettierignore | Added "types/" to be ignored by Prettier in the backend directory |
| README.md | Updated documentation explaining the usage of the new .secret() mixin |
Comments suppressed due to low confidence (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.