Overloaded fillCircleHelper to allow for the drawing of filled quarter circles - #511
Closed
BillMerryman wants to merge 2 commits into
Closed
Overloaded fillCircleHelper to allow for the drawing of filled quarter circles#511BillMerryman wants to merge 2 commits into
BillMerryman wants to merge 2 commits into
Conversation
Contributor
Author
|
@ladyada for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing fillCircleHelper implementation does not allow for drawing filled quarter circles, only half circles. It appears that this is the result of fillRoundRect being dependent on this behavior, and fillCircleHelper was written to support fillRoundRect, thus binding their implementations together. This PR creates an overload of fillCircleHelper that removes the delta argument and accompanying implementation such that drawing quarter circles is now possible while avoiding breaking existing clients.