display: carry all i8080 panel pins in the proto (wr/rd strobes + Add.pin_power)#208
Open
tyeth-ai-assisted wants to merge 1 commit into
Open
display: carry all i8080 panel pins in the proto (wr/rd strobes + Add.pin_power)#208tyeth-ai-assisted wants to merge 1 commit into
tyeth-ai-assisted wants to merge 1 commit into
Conversation
I8080PinDescriptor gains pin_wr(12)/pin_rd(13) — the 8080 bus strobes belong to the interface descriptor like every other bus pin. Add gains an optional pin_power(12) panel power-enable (driven high before init; boards like the LilyGo T-Display-S3 gate the panel rail on a GPIO). Backlight already rides Add.backlight (BacklightConfig). With these, a board's display magic config (d0-d7/cs/dc/wr/rd/rst/backlight/powerOn) maps 1:1 onto the protobuf and the firmware needs no board-hardcoded display pins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per review on adafruit/Adafruit_Wippersnapper_Arduino#936 (the LilyGo T-Display-S3 i8080 display support): every pin in a board's display magic config should come through the protobuf, with no board-hardcoded pins in the firmware.
I8080PinDescriptorgainspin_wr = 12/pin_rd = 13— the 8080 bus strobes belong to the interface descriptor like every other bus pin (rdmay be empty when not wired).Addgains an optionalpin_power = 12— panel power-enable, driven high before init (e.g. the T-Display-S3 gates the panel rail on GPIO15).Add.backlight(BacklightConfig, digitalio/pwm oneof) — unchanged.display.options:max_size:6for the three new pin strings.With these, the LilyGo magic config (
d0–d7 / cs / dc / wr / rd / rst / backlight / powerOn) maps 1:1 onto the proto. Firmware side (nanopb regen + driver wiring, removing theI8080_*board macros) is on adafruit/Adafruit_Wippersnapper_Arduino#936; verified end-to-end on real hardware via the HIL bench.🤖 Generated with Claude Code