pull request for adding reason for update/comment to each saved version#5
Open
elzoiddy wants to merge 23 commits into
Open
pull request for adding reason for update/comment to each saved version#5elzoiddy wants to merge 23 commits into
elzoiddy wants to merge 23 commits into
Conversation
Owner
|
Thanks for the pull request, I just looked at the changes and like them. However, I'm not sure how many people will want/require this reason_for_update. I think part of the appeal of this plugin is that it is light-weight in nature - it only stores the changes. Adding a new reason column may make this seem a little more overkill. What would be ideal in my mind is if we could make this module optional. This would also align with my long-term goal that pieces like reasons, reverts, etc. won't be mandatory but can be opt-in. I don't think it would require many changes right now to adapt this patch to that type of mentality. It should only require:
It will probably take a me a week or so to get around to this. Thanks, |
…tional and :required.
"number" is a reserved word in oracle, so we need alternate column name
…lidation when updating record.
…d has not changed
…want to revert to a previous version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Adam,
I've made a change to add a new column in the versions record called "reason_for_update". It can be used to document the reasons for updating a versioned record or simply make a comment about the change. For many applications (particularly financial) it might be nice to also document the reason as well as what changed for a record. I've added a new test case and modified the migration templates. Everything seems to work as designed. All tests passes with ruby 1.9.2 p0 as well as ruby-1.8.7-p302
Let me know what you think.
Thanks
Example usage: