Make trending gifs optional with a menu option - #167
Open
popthestack wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
One thing: this doesn't remove the little button that refreshes the trending list, so you can still load them. The menu item might be confusing because it just hides them on start? |
Owner
|
@popthestack Could we make the config instead be to choose the default home screen? I'm assuming you want favorites to be the home screen instead. |
Collaborator
Author
|
@adamweeks I like that idea, I'll work on it. |
popthestack
changed the title
adamweeks
previously approved these changes
Feb 25, 2019
Collaborator
Author
|
🎉 I will make more improvements to this later on. |
Owner
|
@popthestack looks like tests are failing with this one 😢 |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make trending gif fetching optional.