ci(.github/workflows): move engine install to databricks/databricks-bot-engine@76a6e590#538
Merged
Merged
Conversation
eric-wang-1990
requested review from
gopalldb,
lidavidm,
msrathore-db and
vikrantpuppala
as code owners
June 21, 2026 06:10
…e590 Repoints all four bot workflows from the personal install repo (eric-wang-1990/databricks-bot-engine) to the org repo (databricks/databricks-bot-engine), and pins ENGINE_REF to 76a6e590 — the initial engine import there, extracted from databricks-driver-test@898d020e. That engine state includes the reviewer fix this PR originally carried (review-phase max_turns 20→100 + explicit out-of-turns failure message), plus the rest of current hub main. The existing BOT_ENGINE_PAT has read access to the org repo, so no secret change is needed. Co-authored-by: Isaac
eric-wang-1990
force-pushed
the
bump-engine-ref-reviewer-turns-cap
branch
from
June 21, 2026 06:58
2c91281 to
df246d7
Compare
eric-wang-1990
changed the title
The four bot workflows now pip-install the engine from the PRIVATE org repo databricks/databricks-bot-engine. That install (and the live-endpoint tests) needs a runner with access to the internal databricks network/org, so move them off ubuntu-latest to the peco-driver self-hosted runner ([self-hosted, Linux, X64, peco-driver]) — the same runner adbc's reyden nightly uses. Resolves the "VERIFY: pick a protected/self-hosted runner" placeholders. Co-authored-by: Isaac
eric-wang-1990
changed the title
eric-wang-1990
added a commit
that referenced
this pull request
Jun 21, 2026
…er) (#539) ## Problem After moving the bot workflows to the self-hosted **peco-driver** runner (#538), `actions/setup-python` fails there: > Version 3.11 was not found in the local cache … not found for this operating system. Self-hosted runners have no GitHub tool-cache (that's why setup-python "just worked" on `ubuntu-latest`), and this one can't reach the version manifest. ## Fix The runner is provisioned with system **python3.11** + **Node**. All four bot workflows drop `actions/setup-python` and instead build a venv from the runner's `python3.11`, put on `$GITHUB_PATH` so later `pip` / `python -m …` steps resolve to 3.11 unchanged. Node (for `@anthropic-ai/claude-code`, which the Python SDK shells out to) comes from the runner. Followup workflows keep their `if: skip != 'true'` guard. YAML validated; title checked against adbc's checker. ## Requires (runner provisioning, one-time) `python3.11` + `python3.11-venv` and Node/npm installed on the peco-driver runner and on the runner service's PATH. This pull request and its description were written by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related changes to all four bot workflows:
eric-wang-1990/databricks-bot-enginetodatabricks/databricks-bot-engine, pinned toENGINE_REF: 76a6e5902b217606b72a9476636df0d761260846(initial org import, extracted fromdatabricks/databricks-driver-test@898d020e).runs-on: [self-hosted, Linux, X64, peco-driver](wasubuntu-latest). The install pulls from a private org repo and the tests hit the live endpoint, so the job must run on a runner with access to the internaldatabricksnetwork/org — the same runner adbc's reyden nightly uses. Resolves the "VERIFY: pick a protected/self-hosted runner" placeholders.Why
The canonical published engine moved from a personal repo to the org repo.
76a6e590includes the reviewer fix this PR originally carried (review-phasemax_turns20→100 + explicit out-of-turns failure, fixing the reviewer death on #536) plus current hubmain.Secret
The existing
BOT_ENGINE_PATreads the org repo (confirmed) — no secret change needed. It just has to be reachable from the peco-driver runner.Verify
After merge, re-run the reviewer on #536 — it should complete with
max_turns=100(or fail with the explicit cap message).This pull request and its description were written by Isaac.