Skip to content

docs: combine validation test bind and ingest tables#108

Merged
lidavidm merged 9 commits into
adbc-drivers:mainfrom
amoeba:docs/combined-bind-ingest-tables
Nov 24, 2025
Merged

docs: combine validation test bind and ingest tables#108
lidavidm merged 9 commits into
adbc-drivers:mainfrom
amoeba:docs/combined-bind-ingest-tables

Conversation

@amoeba

@amoeba amoeba commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

What's Changed

  • Renames the headers for the tables to be simpler: Just "$VENDOR_NAME to Arrow" and "Arrow to $VENDOR_NAME"
  • Combines the bind and ingest type mapping tables into one.

Closes #107

@amoeba

amoeba commented Nov 20, 2025

Copy link
Copy Markdown
Contributor Author

Preview https://691faa1c9620b5ec9f61b094--boisterous-dolphin-37e948.netlify.app/drivers/mysql/#arrow-to-mysql

Three things:

  1. I still want to figure out how to colspan=2 when both types are the same
  2. This exposed one issue I need to look at: For "float" in the Arrow to MySQL table, we have no result for Ingest so this currently shows "None"
  3. I also want to improve the combined table headers, I think I can do that when I do 1.

@amoeba

amoeba commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

Using a list-table and just handling the case where the types aren't the same is pretty readable. Here's what that looks like changed:

Screenshot 2025-11-20 at 4 10 45 PM

@ianmcook

Copy link
Copy Markdown

👍 That seems like a good workaround if there's no clean way to do colspan=2.

@lidavidm

Copy link
Copy Markdown
Contributor

You can just directly generate HTML instead of relying on list-table if you want colspan. You may have to manually add the necessary CSS classes to satisfy the material theme.

@amoeba
amoeba marked this pull request as ready for review November 22, 2025 02:24
@amoeba
amoeba requested a review from lidavidm as a code owner November 22, 2025 02:24
@amoeba

amoeba commented Nov 22, 2025

Copy link
Copy Markdown
Contributor Author

I just went with raw HTML but was able to get something reasonable, see https://69211407df11503fc41bccc3--vermillion-kringle-ffe824.netlify.app/drivers/mysql/#arrow-to-mysql.

@lidavidm
lidavidm merged commit ba1e2e0 into adbc-drivers:main Nov 24, 2025
3 checks passed
@lidavidm

Copy link
Copy Markdown
Contributor

I should set the jinja2 option that automatically collapses spaces so that we don't have to fiddle with - all the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify the type mappings tables

3 participants