fix(utility): use errno.ECONNREFUSED for cross-platform port detection; fix typo#442
Open
suradadhanush wants to merge 1 commit into
Open
fix(utility): use errno.ECONNREFUSED for cross-platform port detection; fix typo#442suradadhanush wants to merge 1 commit into
suradadhanush wants to merge 1 commit into
Conversation
…n; fix typo - Replace hardcoded 111 with errno.ECONNREFUSED (resolves correctly on Windows/Linux) - Fix typo: 'avilable' -> 'available' in print statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Cross-platform (Medium):
result == 111hardcodes the Linux-specific value forECONNREFUSED. On Windows the equivalent is10061—get_free_port()silently returnsNoneon Windows, meaning challenge containers never start.Typo (Low): Print statement says
"avilable"instead of"available".Fix
import errnoaddedresult == 111replaced withresult == errno.ECONNREFUSED— Python resolves this to the correct value per platform at runtimeTesting
errno.ECONNREFUSED == 111— zero functional changeerrno.ECONNREFUSED == 10061— port detection now works correctlyerrnois used immediately after import