fix(uninstaller): replace WindowsError with OSError for cross-platform compatibility#444
Open
suradadhanush wants to merge 1 commit into
Open
Conversation
…m compatibility - WindowsError is undefined on Linux/macOS — raises NameError if exception path is hit - OSError catches WindowsError on Windows identically — zero functional change there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
except WindowsError:raisesNameError: name 'WindowsError' is not definedon Linux and macOS — exactly where PyGoat runs in Docker. If the exception path inis_user_admin()is triggered on a non-Windows host, the script crashes.Fix
Replace
WindowsErrorwithOSError. On Windows,WindowsErroris a subclass ofOSErrorso behaviour is identical. On Linux/macOS,OSErroris natively defined and handles the same conditions.Testing
NameErrorwhen exception path is triggeredOSErrorcatchesWindowsError— identical behaviour