Fix infinite loop in wait_for_health() when container has no HEALTHCHECK configured#513
Open
mohityadav8 wants to merge 1 commit into
Open
Conversation
Contributor
|
The updated Also, a small note: the |
Contributor
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #512
Overview
Fixes an issue where the
wait_for_health()function could loop until timeout when a container has noHEALTHCHECKconfigured.Problem
When a container does not define a HEALTHCHECK in its Dockerfile, Docker returns
Nonefor the health status.The existing implementation did not handle this case, causing the loop to continue until the timeout was reached. This results in unnecessary waiting and incorrect behavior.
Solution
Added explicit handling for the
Nonehealth status.If
health_statusisNone, the function immediately returnsTrue, since the container has no healthcheck configured and waiting is unnecessary.