Fix dead code in toggle_theme() by implementing theme cookie toggle#514
Open
mohityadav8 wants to merge 4 commits into
Open
Fix dead code in toggle_theme() by implementing theme cookie toggle#514mohityadav8 wants to merge 4 commits into
mohityadav8 wants to merge 4 commits into
Conversation
Fixes BUG in dockerized_labs/template_injection_lab/app.py. The toggle_theme() function previously returned a 204 response without performing any action, making the theme toggle feature non-functional. This update: - Reads the current theme from cookies - Toggles between light and dark theme - Sets the updated theme using response.set_cookie() This removes the dead code and restores expected theme toggle functionality.
Refactor theme toggle functionality and remove duplicate imports.
Garvita-k
reviewed
Apr 19, 2026
RupakBiswas-2304
requested changes
Apr 20, 2026
Contributor
Author
|
@RupakBiswas-2304 @Garvita-k My bad — I accidentally removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BUG in
dockerized_labs/template_injection_lab/app.py.The toggle_theme() function previously returned a 204 response without performing any action, making the theme toggle feature non-functional.
This update:
This removes the dead code and restores expected theme toggle functionality.