feat(gateway): add a helm chart that deploys a kgateway gateway by piuswa · Pull Request #1770 · adfinis/helm-charts

piuswa · 2026-04-02T08:40:33Z

Description

This PR introduces a new chart that deploys a kgateway gateway.
Optional Features:

HorizontalPodAutoscaler
PodDisruptionBudget
NetworkPolicy
PodMonitor
ListenerPolicy for access logging and ProxyProtocol configuration
HTTP traffic can be redirected to HTTPS.

Issues

In internal tracker

Checklist

This PR contains a description of the changes I'm making
I updated the version in Chart.yaml
I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
I updated applicable README.md files using pre-commit run
I documented any high-level concepts I'm introducing in docs/
CI is currently green and this is ready for review
I am ready to test changes after they are applied and released

hairmare · 2026-04-02T09:16:07Z

@@ -0,0 +1,24 @@
+{{- if .Values.otelcol.enabled }}


shouldn't this be in the upstream otel chart?

This can not be in the upstream chart, because ListenerPolicy is a kgateway specific object and therefore has to be defined with the gateway.

did we consider stashing it in extraManifests for now?

Removed and integrated into the primary listenerpolicy for the gateway.

Since the otelcol dependency was removed here (the listenerpolicy config is specifically an opentelemetry compatible grpc endpoint), I think this can be resolved.

hairmare · 2026-04-02T09:18:05Z

@@ -0,0 +1,77 @@
+{{- if .Values.podMonitor.enabled }}
+apiVersion: monitoring.coreos.com/v1
+kind: PodMonitor


Would it be possible to use a ServiceMonitor?

The service created with the gateway by the controller does not expose the metrics port.

We'll create a separate metrics service here and point the servicemonitor to it.

sire, this is a PodMonitor, how can we point to a ServiceMonitor if this creates a PodMonitor?

Pod Monitor has been removed and changed to a Service Monitor

hairmare · 2026-04-02T09:21:55Z

+spec:
+  scaleTargetRef:
+    apiVersion: apps/v1
+    kind: Deployment


Who manages this Deployment? Shouldn't it deploy Deployment related resources like HPAs?

The Deployment is managed by the Gateway resource. As of version 2.2.2 of kgateway it is not possible to configure this using GatewayParameters. This will be possible in version 2.3.0 which is still in beta. Same goes for the PodDisruptionBudget.

When to we expect 2.3.0 to be GA? If it's soon then we might as well skip adding them here.

They seem to be halfway there currently with no due date set. Not really sure when to expect it.

if they follow a quarterly release cycle, then i would assume that they release 2.3 in early may. my hope would also be that the release aligns with whatever plans upstream gateway-api sig has.

As gateway api does not have a deterministic release cycle, it's a bit hard to anticipate:
https://gateway-api.sigs.k8s.io/contributing/release-cycle/

For instance, gateway api v1.5 was released on February 27th. A beta release of kgateway supporting this version of gateway api was cut on March 20th (v2.3.0-beta.3).

What changes with 2.3.0 as well is the creation of HPA and PDB resources using the gateway parameters.
Right now, we do this along with the chart. I think that's okay, since it's a minor change afterwards and shouldn't be user-facing.

At the current pace I do expect the 2.3 release to be sometime in May as well.

Keep in mind updating gateway-api can also depend on other components, such as support by cert-manager and external-dns, as well as support by installed helm charts deploying routes on API version changes.

Given how soon we expect 2.3.0 to be released, would early adopting it's beta help us keep this change smaller? How would that fit with out roadmaps?

…ice that exposes necessary port

…ctions

…r policy

cfi2017

Once @hairmare 's comments are resolved this looks good to me.

hairmare · 2026-04-16T09:24:29Z

Once @hairmare 's comments are resolved this looks good to me.

I might have more, the feedback i have so far was only from a quick initial scan of the change.

This also feels like it would benefit very much from some links (to issues that ask for the features from here in upstream) and a real explanation as to why it's needed.

dominrivera

LGTM.
Just @cfi2017 do you think we can define something in here to fulfill this request? https://git.adfinis.com/ch-cloudnative/team-coordination/-/work_items/744#note_889098

Waiting for answer: #1770 (review)

piuswa requested a review from cfi2017 April 2, 2026 08:40

hairmare reviewed Apr 2, 2026

View reviewed changes

Comment thread charts/gateway/values.yaml Outdated

hairmare reviewed Apr 2, 2026

View reviewed changes

piuswa force-pushed the feat/add-gateway branch from 97fba7e to beffd1e Compare April 15, 2026 12:39

piuswa added 4 commits April 15, 2026 14:46

feat(gateway): add a helm chart that deploys a kgateway gateway

db26e90

fix(chart.yaml): add annotations for artifacthub.io

e8461e7

fix(otelcol): remove otelcol chart

e75e7a4

fix(monitoring): remove pod monitor and add service monitor with serv…

54b7f64

…ice that exposes necessary port

piuswa force-pushed the feat/add-gateway branch from beffd1e to 54b7f64 Compare April 15, 2026 12:47

piuswa added 2 commits April 15, 2026 15:23

fix(chart-testing): add CRDs for Gateway API and kgateway to github a…

56abdee

…ctions

fix(listener-policy): move access log configuration to gneral listene…

7edeca8

…r policy

piuswa marked this pull request as ready for review April 15, 2026 14:07

piuswa requested a review from a team as a code owner April 15, 2026 14:07

piuswa requested review from dominrivera and inisitijitty April 15, 2026 14:07

cfi2017 previously approved these changes Apr 16, 2026

View reviewed changes

dominrivera previously approved these changes Apr 20, 2026

View reviewed changes

Merge branch 'main' into feat/add-gateway

663d3e8

piuswa dismissed cfi2017’s stale review via 663d3e8 May 21, 2026 09:23

Uh oh!

Conversation

piuswa commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cfi2017 left a comment

Choose a reason for hiding this comment

Uh oh!

hairmare commented Apr 16, 2026

Uh oh!

dominrivera left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

piuswa commented Apr 2, 2026 •

edited

Loading