[BOURNE-2565] Sync with upstream#1499
Closed
gregbaroni wants to merge 18 commits intoadorsys:mainfrom
Closed
Conversation
When "remote state" is enabled for clients (the default), Keycloak will only delete clients that were listed in the config tool's state. This prevents it from deleting clients that it didn't create. When deciding what to delete, we can just fetch the clients that were already in the state, rather than listing all the clients in the realm. This should be a much smaller list, and prevents issues where the server cuts off the response when the list is too large.
It's difficult to avoid all situations where we need to list all the clients in the realm. If we try fetching them all in one request, it can fail because the response is cut off by the server. As long as we're using reasonably-sized pages, we should avoid resource limits and actually run much faster.
Previously, searchByName() was fetching all groups and filtering. This now uses `?search=<name>&exact=true`. There is still another place where it is fetching all groups. For now, we'll add pagination, but eventually we'll want to fix this.
…emains the same) (#15)
…t long-running query (#17)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved merge conflicts
Client Pagination
Ours: BOURNE-1686: Use pagination when fetching all clients
Upstream: feat: get all clients by page of 100
Their fix only paginates one place using whereas we use our paginator in multiple places. So, I kept our change.
Auth Flow Recreation
Ours: Prevent recreating auth flows if priority values changed (but order remains the same)
Upstream: fix(auth-flows): normalize execution priorities for stable flow comparison
Their fix covers more than just execution priorities. So, I kept their change.
Authorization Import
Ours: Retrieve realm-management client authz information in parts to prevent long-running query
Upstream: fix: create authorization scopes before resources to ensure proper binding
These are unrelated, but I updated our implementation to also create the scopes before the authorization resources.