Open
Conversation
mbiti2
requested review from
Motouom and
Nkwenti-Severian-Ndongtsop
and removed request for
Motouom and
Nkwenti-Severian-Ndongtsop
mbiti2
force-pushed
the
fix/first-broker-login-flow
branch
from
e754680 to
06c878e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the HTTP 500 Internal Server Error (NullPointerException) that occurs when importing a realm configuration that defines a custom firstBrokerLoginFlow and its corresponding authentication flow in the same import. The issue was that firstBrokerLoginFlow was being sent to Keycloak before the referenced authentication flow was created.
The fix adds firstBrokerLoginFlow to the list of ignored properties during initial realm import, then explicitly sets it after authentication flows are created (similar to how browserFlow, registrationFlow, etc. are handled).
Which issue this PR fixes: fixes #1481
How this PR was tested:
Screenshots / logs (if relevant):
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:mvn testor relevant subset)CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR